Note unicode handling. * morituri/test/test_image_image.py: * morituri/image/table.py: * morituri/program/cdparanoia.py: * morituri/common/checksum.py: Use unicode for paths. Use repr for path representation. * morituri/test/test_common_checksum.py: Add test for unicode audio file name.
31 lines
981 B
Plaintext
31 lines
981 B
Plaintext
style guide
|
|
-----------
|
|
|
|
To avoid confusion:
|
|
|
|
- cuefile is used for the CueFile object, which wraps/parses an existing .cue
|
|
file on disk
|
|
- tocfile: same
|
|
- toc: table of contents of a CD; instance of Table
|
|
|
|
|
|
test: single rip of kings of leon - only by the night
|
|
|
|
track 1: frame start 0, 17811 CD frames,
|
|
track 2: frame start 17811, 18481 CD frames
|
|
ARCue.pl says 2c15499a
|
|
track 11: frame start 166858, 25103 CD frames (14760564 audio frames)
|
|
|
|
191961 total CD frames
|
|
|
|
unicode
|
|
-------
|
|
- All text files should be read and written as unicode.
|
|
- All strings that came from the outside should be converted to unicode objects.
|
|
- Use asserts liberally to ensure this so we catch problems earlier.
|
|
- All gst.parse_launch() pipelines should be passed as utf-8; use
|
|
encode('utf-8')
|
|
- morituri.extern.log.log is not unicode-safe; don't pass it unicode objects;
|
|
for example, always use %r to log paths
|
|
- run with RIP_DEBUG=5 once in a while to catch unicode/logging errors.
|