benya/whipper-gui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,413 Commits 1 Branch 10 Tags
fe13affac29516116fc564f6adec2ebf8488e4ff
Commit Graph

1413 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
JoeLametta
fe13affac2 Merge pull request #409 from whipper-team/bugfix/issue-361-drive-analysis-fails 
Fix erroneous result message for whipper drive analyze
 2019-10-21 16:30:03 +02:00
JoeLametta
14fb96e87c Merge pull request #408 from whipper-team/bugfix/issue-354-eliminate-eject-warning 
Report eject's failures as logger warnings
 2019-10-21 16:26:58 +02:00
JoeLametta
3b2b732516 Merge pull request #417 from mtdcr/fast-toc 
Make getFastToc() fast again
 2019-10-20 16:05:17 +02:00
Andreas Oberritter
342bce9be2 Make getFastToc() fast again. 
Broken since #345 was merged.

Signed-off-by: Andreas Oberritter <obi@saftware.de>
 2019-10-20 15:25:17 +02:00
Andreas Oberritter
252a2e8141 Use ittoc only for CDDB and MusicBrainz lookups 
The data from itable may be more accurate, because ittoc comes from
getFastToc().

Signed-off-by: Andreas Oberritter <obi@saftware.de>
 2019-10-20 15:25:17 +02:00
JoeLametta
635113be9a Fix incorrect frames to MSF conversion 
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2019-08-19 12:00:00 +00:00
JoeLametta
e5961ae04c Report eject's failures as logger warnings 
If the eject command exits with an error, the output is logged as a WARNING. I don't think it's a good idea to mask those errors.

Closes #354.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2019-07-07 12:00:00 +00:00
JoeLametta
048a31e348 Fix erroneous result message for whipper drive analyze 
If cdparanoia fails to analyze the drive, the drive is now marked as unable to defeat the cache.

Fixes #361.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2019-07-07 10:00:00 +00:00
JoeLametta
57d386e82f Remove too verbose logger statements 
Related to #278.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2019-07-07 10:00:00 +00:00
it is madness
0d69258654 Use YAML 1.2 boolean values for booleans 
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2019-07-06 16:00:00 +00:00
JoeLametta
b5f0af21be Merge pull request #406 from vmx/fix-offset-find 
Fix offset find command
 2019-07-05 11:18:49 +02:00
JoeLametta
4eeb0cddc7 Update failing AccurateRipResponse tests 2019-07-05 08:00:00 +00:00
Volker Mische
9cf890a6e2 Fix offset find command 
The refactoring of `ReadTOCTask` in commit 3e79032b63
broke the `offset find` command. This commit fixes it again.

Signed-off-by: Volker Mische <volker.mische@gmail.com>
 2019-07-05 00:06:02 +02:00
Thomas Vander Stichele
7a4680f285 Add testcase for Gentlemen: same CDDB ID as Interpol 
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2019-05-09 09:46:28 +02:00
JoeLametta
3a74c60344 Update "required dependencies" section in README 
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2019-05-04 10:18:03 +02:00
JoeLametta
bb78dc109d Merge pull request #387 from whipper-team/feature/issue-383-restructuredtext 
Convert documentation from epydoc to reStructuredText
 2019-05-03 20:11:09 +02:00
JoeLametta
69f8f39c49 Change documentation from epydoc to reStructuredText 
Thanks to Freso for all the useful comments!

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2019-05-03 20:06:13 +02:00
JoeLametta
8db090c9bf Add Freso to whipper's credits 
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2019-05-03 19:19:16 +02:00
JoeLametta
ccfe724e2e Merge pull request #392 from gorgobacka/default_success 
Set default for eject to: success
 2019-05-03 12:28:28 +02:00
JoeLametta
78b3c0d56a Merge pull request #391 from gorgobacka/perform_eject 
Use eject value of the class again
 2019-05-03 12:28:00 +02:00
gorgobacka
eff5fee3f4 use self.eject 
Signed-off-by: gorgobacka <tho.b.j@gmx.de>
 2019-05-03 12:25:48 +02:00
Frederik “Freso” S. Olesen
bb6a29c5df Update Travis config for Python specific handling 
See the Python documentation for more information:
https://docs.travis-ci.com/user/languages/python/

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2019-05-03 11:43:43 +02:00
JoeLametta
7a92650eff Update Docker Hub's repository URL 
See #395.
 2019-05-03 10:46:24 +02:00
JoeLametta
a9b6e3c91b Merge pull request #398 from whipper-team/bugfix/issue-396-no-mb-release-group-type 
Make whipper not break on missing release type
 2019-05-03 10:16:12 +02:00
Frederik “Freso” S. Olesen
bf8daf186d mbngs: Let releaseType be None if no type is set 
Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-05-03 02:49:42 +02:00
Frederik “Freso” S. Olesen
f74455c9f0 mblookup: Cast None to unicode before encoding 
Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-05-03 02:43:31 +02:00
Frederik “Freso” S. Olesen
c2459067ce Test mblookup output when release type is missing 
Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-05-03 02:38:38 +02:00
Frederik “Freso” S. Olesen
885ad172a8 Set release type to empty string if none is given 
Fixes https://github.com/whipper-team/whipper/issues/396

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-05-02 18:37:51 +02:00
Frederik “Freso” S. Olesen
8209927a79 Add testcase for failure when missing release type 
See https://github.com/whipper-team/whipper/issues/396

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-05-02 18:35:42 +02:00
JoeLametta
3a61960e5f Add git/mercurial dependency to the README 
Building or running whipper uninstalled requires setuptools-scm (since #370): which depends on git (or mercurial) in order to to its job.

Fixes #386.
 2019-04-02 15:27:22 +00:00
JoeLametta
1ae6240e63 Remove useless "stopgap morituri-insanity compatibility layer" 
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2019-03-29 13:34:39 +01:00
gorgobacka
a977f9b7f6 set success as default 
Signed-off-by: gorgobacka <tho.b.j@gmx.de>
 2019-03-27 23:16:21 +01:00
Frederik “Freso” S. Olesen
135cc9ce05 Include MusicBrainz Release URL in log output (#382) 
* Include MusicBrainz Release URL in log output

This also passes *all* metadata to the `result` object, giving loggers a
lot more (release) metadata to work with, in case custom, “3rd party”
loggers (or even ourselves in the future!) want to do something more
fancy or expansive with the metadata in the log file.

Fixes https://github.com/whipper-team/whipper/issues/381

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>

* Uppercase "url" in output: "URL"

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-03-18 11:15:27 +00:00
Frederik “Freso” S. Olesen
a9bb51a0cf Specify supported version(s) of Python in setup.py 
In preparation for dropping Python 2.7 support[1], this specifies
versions that *are* compatible with Python 2.7, so anyone installing via
pip (if we end up publishing to PyPI) will get the proper version.

See https://packaging.python.org/guides/dropping-older-python-versions/

[1] https://github.com/whipper-team/whipper/issues/78

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-03-01 11:12:14 +01:00
JoeLametta
e26bb24998 Merge pull request #371 from whipper-team/bugfix/issue-369-attributeerror 
Fix critical regressions introduced in 3e79032 and 16b0d8d
 2019-02-19 15:48:00 +01:00
JoeLametta
8d4f818754 Fix critical regressions introduced in 3e79032 and 16b0d8d 
Fixes #369.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2019-02-19 15:42:32 +01:00
JoeLametta
f9884add1b Add git dependency to Dockerfile 
Required by setuptools_scm.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2019-02-18 17:32:56 +01:00
Frederik “Freso” S. Olesen
2b6b0059aa Remove references to "python-cddb" 
The use of this Python package was replaced in commit
542e071443 with another CDDB/FreeDB API
implemention, but it was still being installed for Travis CI builds and
for Docker containers.

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-16 03:34:17 +01:00
JoeLametta
79cb5ef68f Merge pull request #367 from whipper-team/feature/use-multivalue-artistid-tags 
Handle artist MBIDs as multivalue tags
 2019-02-15 18:44:12 +01:00
JoeLametta
d066c70cc4 Merge pull request #370 from whipper-team/task/issue-337-use-scm-version 
Use git to get whipper's version
 2019-02-15 18:32:02 +01:00
Frederik “Freso” S. Olesen
af748c55b7 Use git to get whipper's version 
This essentially a copy of code from spotify2musicbrainz:
59157165c4

Given that that code is in GPLv3 (and I'm its author :)), it should be
fine to use. It is mostly boilerplate from upstream documentation
anyway: https://pypi.org/project/setuptools-scm/

Should fix https://github.com/whipper-team/whipper/issues/337

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-14 11:55:21 +01:00
Frederik “Freso” S. Olesen
6abd120e4a Fix calls to cdrdao.ReadTOCTask() 
Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-14 00:49:02 +01:00
Frederik “Freso” S. Olesen
1a1ddd524a README: Update copyright attribution of my own name 
Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-13 23:57:11 +01:00
Frederik “Freso” S. Olesen
787dbb91f6 Update copyright statement year range in README 
Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-13 23:55:50 +01:00
Frederik “Freso” S. Olesen
239fc3e6ae Lowercase description of "%R" template variable 
All other descriptions are lowercased, except for this one.

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-13 23:13:45 +01:00
Frederik “Freso” S. Olesen
14aa8b7f7c Handle artist MBIDs as multivalue tags 
Instead of joining artist MBIDs with a ';' save them as multiple values
to the tag. (This is how Picard saves that tag.)

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-13 22:59:58 +01:00
Frederik “Freso” S. Olesen
42e7a77645 Remove unused argument for ….mbngs._getMetadata() 
Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-13 22:07:59 +01:00
JoeLametta
94b7001fad Merge pull request #366 from whipper-team/feature/issue-200-add-more-musicbrainz-identifiers 
Add Track, Release Group, and Work MBIDs to ripped files
 2019-02-13 21:35:02 +01:00
Frederik “Freso” S. Olesen
364f024c08 Add Work MBIDs to ripped files 
See https://musicbrainz.org/doc/Work

Third and final and thus closes https://github.com/whipper-team/whipper/issues/200

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-13 21:01:57 +01:00
JoeLametta
87b9460639 Change musicbrainzngs logging level to WARNING 
The default log level is INFO.
Needed to silence harmless messages like: '<ws2:release-group>, uncaught attribute type-id'.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2019-02-13 20:13:09 +01:00