benya/whipper-gui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,362 Commits 1 Branch 10 Tags
fa5add0309e8fde6acdea1ec3e2aa14fcca4320e
Commit Graph

1362 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Frederik “Freso” S. Olesen
fa5add0309 Simplify setting release type 
We pull in the Release Group information now directly in the original
MusicBrainz web service request, so no need to do further processing
to get it.

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-13 19:51:30 +01:00
Frederik “Freso” S. Olesen
c963b0173b Add Release Group MBIDs to ripped files 
See https://musicbrainz.org/doc/Release_Group

Second part of https://github.com/whipper-team/whipper/issues/200

(MusicBrainz JSON test data dumps needed to be refreshed due to the
new `includes` in the MusicBrainz web service call.)

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-13 19:03:15 +01:00
Frederik “Freso” S. Olesen
41b1b1feff Add Track MBIDs to ripped files 
See https://musicbrainz.org/doc/Track

First part of https://github.com/whipper-team/whipper/issues/200

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-13 18:59:11 +01:00
JoeLametta
1cf784ca7f Merge pull request #365 from whipper-team/task/refresh-musicbrainz-json-responses 
Refresh MusicBrainz JSON responses used for testing
 2019-02-13 18:43:56 +01:00
Frederik “Freso” S. Olesen
fce00f492e Change release used for testing [unknown] artist credits 
The previously used release has since had its [unknown] artist credit
resolved since the data was originally taken from MusicBrainz.

Using data from this release now:
https://musicbrainz.org/release/8478d4da-0cda-4e46-ae8c-1eeacfa5cf37
Specifically:
https://musicbrainz.org/track/a04ee451-46c3-3ad6-a815-d7bb8449d605

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-13 18:35:48 +01:00
Frederik “Freso” S. Olesen
6d3f44ba96 Change release used for testing missing release date 
The previous release has gotten a release date added since it was
originally dumped from MusicBrainz.

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-13 18:35:28 +01:00
Frederik “Freso” S. Olesen
a08bbeea6a Refresh MusicBrainz JSON dumps used for testing 
Some of these dumps predate when MusicBrainz had (re)introduced track
MBIDs, so some tests for the code for issue #200 would fail since the
JSON dumps didn't contain those IDs.

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-13 16:47:01 +01:00
JoeLametta
8266368c7d Merge pull request #364 from whipper-team/task/cleanup-musicbrainz-nomenclature 
Clean up MusicBrainz nomenclature
 2019-02-13 15:29:33 +01:00
JoeLametta
7b811c85a6 Merge pull request #363 from whipper-team/bugfix/spaces_before_barcode 
Fix misaligned output in command.mblookup
 2019-02-13 15:20:29 +01:00
Frederik “Freso” S. Olesen
2c464bc732 Fix MusicBrainz nomenclature: track vs. recording 
For historical reasons there is some confusion between Tracks[1] and
Recordings[2] in MusicBrainz. Essentially what should be saved to
`MUSICBRAINZ_TRACKID` is the Recording MBID—which is what whipper is
correctly doing, but the value storing this value was called `mbidTrack`
rather than `mbidRecording`, which could potentially cause confusion.

[1] https://musicbrainz.org/doc/Track
[2] https://musicbrainz.org/doc/Recording

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-13 15:03:31 +01:00
Frederik “Freso” S. Olesen
75c5646d1e Fix MusicBrainz nomenclature: album → release 
In general, "albums" in everyday usage is what on MusicBrainz would be
considered a release group[1] while as far as I can tell, every single
instance of it being used in whipper is referring to a single "edition"
of an album, which is what would be called a "release" in
MusicBrainz terminology[2].

[1] https://musicbrainz.org/doc/Release_Group
[2] https://musicbrainz.org/doc/Release

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-13 14:55:45 +01:00
Frederik “Freso” S. Olesen
e91fe2720b command.mblookup: Fix misaligned output. 
Only three spaces before "Barcode" instead of four.

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-13 14:35:34 +01:00
JoeLametta
952428993d Merge pull request #362 from whipper-team/update-accuraterip-checksum 
Update accuraterip-checksum
 2019-02-11 19:44:33 +01:00
leo-bogert
fabd50dfb7 Update accuraterip-checksum to v1.5 
https://github.com/leo-bogert/accuraterip-checksum/releases/tag/version1.5

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
 2019-02-11 18:56:47 +01:00
JoeLametta
c07e74d0fa Merge pull request #358 from whipper-team/feature/developer-certificate-of-origin 
Require Developer Certificate of Origin sign-off
 2019-02-02 19:31:49 +01:00
JoeLametta
77679e822a Merge pull request #357 from whipper-team/bugfix/idea-issues 
Address warnings/errors from various static analysis tools
 2019-02-02 19:24:26 +01:00
JoeLametta
9dc5702e19 Fix string concatenation bug 2019-02-02 19:19:50 +01:00
JoeLametta
f79fb32340 Remove broken assertion 2019-02-02 19:19:50 +01:00
JoeLametta
cf923cc9cc Review existing comments and add new ones 
Also clarified a statement
 2019-02-02 19:19:50 +01:00
JoeLametta
fe36241730 Don't assign the result of a function that returns no value 2019-02-02 19:19:49 +01:00
JoeLametta
ad66af900f Remove erroneous extra format argument 2019-02-02 19:19:49 +01:00
JoeLametta
6bb585e1a5 Replace if ... else ... with simpler statement 2019-02-02 19:19:49 +01:00
JoeLametta
e7bfc34c0e Rename 'throwaway' variables to single underscore 
Also removed unused ones
 2019-02-02 19:19:49 +01:00
JoeLametta
16b0d8dc29 Make methods static 2019-02-02 19:19:49 +01:00
JoeLametta
af90c1c338 Fix unresolved reference 2019-02-02 19:19:49 +01:00
JoeLametta
5311727572 Avoid shadowing built-ins/variables 2019-02-02 19:19:49 +01:00
JoeLametta
fef7973113 Modernize code for easier Python 3 port 
- Replace print statement with function call
- Replace except ..., ...: syntax with except ... as ...:
- Simplify obsolete try ... except ... code block
- Replace some unicode calls with u-prefixed strings
- Do not use `len(SEQUENCE)` to determine if a sequence is empty
- Replace dictionary creation
- Drop support for GObject static bindings
 2019-02-02 19:19:49 +01:00
JoeLametta
0e17b32740 Various stylistic fixes 
- Fix PEP8's line too long warning
- Remove useless parentheses
- Use triple quotes for docstring
- Address pylint's 'inconsistent-return-statements'
- Specify string format arguments as logging function parameters
- Comment out already disabled block of code
- Remove useless else (after return)
- Remove useless statement
- Do not import already imported module
 2019-02-02 19:19:46 +01:00
JoeLametta
8dfcc5b5ec Improve regular expressions 
- Remove redundant escape
- Remove erroneous character
- Remove duplicate character
 2019-02-02 18:39:14 +01:00
JTL
3e79032b63 WIP: Refactor cdrdao toc/table functions into Task and provide progress output (#345) 
* Begin work on moving cdrdao to a task

* Add code to start cdrdao task

* Allow cdrdao output to be asynchronously parsable

* Provide progress of cdrdao read toc/table to console

* Flake8 fixes, Freso's advices
 2019-02-02 18:36:03 +01:00
JoeLametta
f99ffd77fd Require Developer Certificate of Origin sign-off 2019-01-18 12:15:59 +01:00
JoeLametta
752b485d28 Merge pull request #353 from rekh127/patch-1 
Clarify format option for disc template
 2019-01-17 22:07:18 +00:00
Daniel Butler
05495537a0 Clarify format option for disc template 
The previous text implied to me that this was the sort name for the Album/Disc title.  Not the artist sort name.
 2019-01-13 18:30:24 -08:00
JoeLametta
1a9197ece2 Merge branch 'release/0.7.3' 2018-12-14 23:35:57 +01:00
JoeLametta
3f0ccba727 Push whipper v0.7.3 release 2018-12-14 22:14:30 +00:00
JoeLametta
7c83670efa Clarify cd-paranoia's package issue 
Also updated pycdio/libcdio section

Fixes #347.
 2018-12-14 22:14:30 +00:00
JoeLametta
951082dad1 Merge pull request #348 from whipper-team/bugfix/issue-135-plugins-from-system 
Discover plugins in system directories too
 2018-12-14 21:21:21 +00:00
JoeLametta
3a569484e3 Discover plugins in system directories too 
Fixes #135.
 2018-12-14 22:16:13 +01:00
JoeLametta
c803a59d87 Fix whipper cd rip menu bug (loggers list) 2018-12-14 21:52:12 +01:00
JoeLametta
1349968245 Restore stdout flushing 
Otherwise it seems that the output of some lines may appear garbled
 2018-12-14 14:29:14 +00:00
JoeLametta
92cbb88f1f Avoid double showing the same error message 2018-12-14 14:21:56 +00:00
JoeLametta
a4f654a3f3 Fix logger statements having multiple arguments 
Some of the instructions have been rendered invalid during the conversion to logger statements...

Also performed various stylistic fixes
 2018-12-14 14:21:56 +00:00
JoeLametta
a23b214814 Print empty lines, not parentheses 2018-12-14 14:21:51 +00:00
JoeLametta
e3bb215d4f Convert noisy logger statements to debug level 2018-12-14 14:17:30 +00:00
JoeLametta
c377417108 Replace sys.std{out,err} statements with logger/print calls (#331) 
* Change global default log level to 'INFO'

We're going to increase our usage of logger statements instead of print instructions (where deemed opportune).

* Replace sys.std{out,err} statements with logger/print calls

Fixes #303.
 2018-12-13 20:21:26 +00:00
JoeLametta
32cd902821 Merge pull request #323 from whipper-team/feature/issue-215-unicode-issues 
Fix UnicodeEncodeError with non ASCII MusicBrainz's catalog numbers
 2018-12-11 17:50:51 +00:00
JoeLametta
21f73d32a5 Merge pull request #341 from itismadness/patch-1 
Avoid zero padding in logger track numbers
 2018-11-29 22:18:17 +01:00
it is madness
25800e0d3f Avoid zero padding in logger track numbers 
Fixes #340
 2018-11-29 09:41:58 -05:00
JoeLametta
4a53ecba2c Avoid zero padding in logger track numbers 
Fixes #340.
 2018-11-29 08:00:00 +00:00
JoeLametta
4a91898292 Merge pull request #321 from whipper-team/feature/cdrdao-toc-preservation 
Preserve ToC file generated by cdrdao
 2018-11-19 12:02:16 +00:00