benya/whipper-gui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,332 Commits 1 Branch 10 Tags
f99ffd77fd364fdd7d4e5dcfb93d613438b65a14
Commit Graph

1332 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
JoeLametta
f99ffd77fd Require Developer Certificate of Origin sign-off 2019-01-18 12:15:59 +01:00
JoeLametta
752b485d28 Merge pull request #353 from rekh127/patch-1 
Clarify format option for disc template
 2019-01-17 22:07:18 +00:00
Daniel Butler
05495537a0 Clarify format option for disc template 
The previous text implied to me that this was the sort name for the Album/Disc title.  Not the artist sort name.
 2019-01-13 18:30:24 -08:00
JoeLametta
1a9197ece2 Merge branch 'release/0.7.3' 2018-12-14 23:35:57 +01:00
JoeLametta
3f0ccba727 Push whipper v0.7.3 release 2018-12-14 22:14:30 +00:00
JoeLametta
7c83670efa Clarify cd-paranoia's package issue 
Also updated pycdio/libcdio section

Fixes #347.
 2018-12-14 22:14:30 +00:00
JoeLametta
951082dad1 Merge pull request #348 from whipper-team/bugfix/issue-135-plugins-from-system 
Discover plugins in system directories too
 2018-12-14 21:21:21 +00:00
JoeLametta
3a569484e3 Discover plugins in system directories too 
Fixes #135.
 2018-12-14 22:16:13 +01:00
JoeLametta
c803a59d87 Fix whipper cd rip menu bug (loggers list) 2018-12-14 21:52:12 +01:00
JoeLametta
1349968245 Restore stdout flushing 
Otherwise it seems that the output of some lines may appear garbled
 2018-12-14 14:29:14 +00:00
JoeLametta
92cbb88f1f Avoid double showing the same error message 2018-12-14 14:21:56 +00:00
JoeLametta
a4f654a3f3 Fix logger statements having multiple arguments 
Some of the instructions have been rendered invalid during the conversion to logger statements...

Also performed various stylistic fixes
 2018-12-14 14:21:56 +00:00
JoeLametta
a23b214814 Print empty lines, not parentheses 2018-12-14 14:21:51 +00:00
JoeLametta
e3bb215d4f Convert noisy logger statements to debug level 2018-12-14 14:17:30 +00:00
JoeLametta
c377417108 Replace sys.std{out,err} statements with logger/print calls (#331) 
* Change global default log level to 'INFO'

We're going to increase our usage of logger statements instead of print instructions (where deemed opportune).

* Replace sys.std{out,err} statements with logger/print calls

Fixes #303.
 2018-12-13 20:21:26 +00:00
JoeLametta
32cd902821 Merge pull request #323 from whipper-team/feature/issue-215-unicode-issues 
Fix UnicodeEncodeError with non ASCII MusicBrainz's catalog numbers
 2018-12-11 17:50:51 +00:00
JoeLametta
21f73d32a5 Merge pull request #341 from itismadness/patch-1 
Avoid zero padding in logger track numbers
 2018-11-29 22:18:17 +01:00
it is madness
25800e0d3f Avoid zero padding in logger track numbers 
Fixes #340
 2018-11-29 09:41:58 -05:00
JoeLametta
4a53ecba2c Avoid zero padding in logger track numbers 
Fixes #340.
 2018-11-29 08:00:00 +00:00
JoeLametta
4a91898292 Merge pull request #321 from whipper-team/feature/cdrdao-toc-preservation 
Preserve ToC file generated by cdrdao
 2018-11-19 12:02:16 +00:00
JoeLametta
c2af4459ef Preserve ToC file generated by cdrdao 
Whipper uses cdrdao during its ripping process. With this commit it will now store cdrdao's generated tocfile in the ripping path.
Preserving the tocfile allows users to easily burn ripped discs having a non-compliant cue sheet.

Fixes #214.
 2018-11-19 12:56:58 +01:00
JoeLametta
2b286be91c Update failing AccurateRipResponse tests (#334) 
* Update failing AccurateRipResponse tests [1/2]

The failures seem to be caused by a remote metadata change (metadata from AccurateRip about a release ID changed) which means some of the asserts related to a specific release ID are failing. I've fixed this issue with two commits.
This is part 1: here I've updated the confidence values of two tracks making it agree with AccurateRip's remote.

* Update failing AccurateRipResponse tests [2/2]

This is part 2: here I've replaced the outdated AccurateRip bin file with a freshly downloaded one.
 2018-11-17 09:05:34 +00:00
JoeLametta
688574a5d8 Add Probot apps to improve workflow (#329) 
* Add Probot Stale app

* Add Probot Welcome app
 2018-11-13 15:42:28 +00:00
JoeLametta
f1aaaec73a Merge pull request #328 from whipper-team/feature/issue-202-zerodivisionerror 
Raise exception when cdparanoia can't read any frames
 2018-11-09 21:52:40 +01:00
JoeLametta
c0637b1b92 Raise exception when cdparanoia can't read any frames 
This commit effectively reverts #159. Whipper now raises an exception again but with a clearer textual description.

Closes #202.
 2018-11-09 21:47:56 +01:00
JoeLametta
8cec4696d5 Merge pull request #327 from whipper-team/feature/issue-208-offset-find-exception 
Prevent exception in offset find
 2018-11-09 21:41:34 +01:00
JoeLametta
09c3e4771d Prevent exception in offset find 
Whipper offset find needs a (remote) matching AccurateRip entry to perform its task and confirm the drive offset: if none is found, return early to prevent exception.

Fixes #208.
 2018-11-09 21:36:50 +01:00
JoeLametta
d7fd3fb507 Convert print statement to logger warning 
Clarify the description of the error.
 2018-11-09 08:00:00 +00:00
JoeLametta
1449911a6f Merge pull request #325 from whipper-team/feature/fix-template-validation-pr-322 
Fix template validation error
 2018-11-04 12:24:21 +01:00
JoeLametta
4f5b684ec7 Fix template validation error 
Commit 9c72ebccd3 introduced a bug: all template strings are validated against the disc template RegEx (which, for example, is wrong if we're testing the track template).
 2018-11-04 12:17:44 +01:00
JoeLametta
f0fcae872d Write musicbrainz_discid tag when disc is unknown 
Fixes #280.
 2018-11-02 18:47:52 +01:00
JoeLametta
59d5fdb84a Fix UnicodeEncodeError with non ASCII MusicBrainz's catalog numbers 
Fixes #215.
 2018-11-02 17:29:12 +01:00
JoeLametta
9c72ebccd3 Merge pull request #322 from whipper-team/feature/issue-279-disc-template-keyerror 
Raise exception if template has invalid variables
 2018-11-02 15:11:27 +00:00
JoeLametta
69bac864ab Raise exception if template has invalid variables 
If the template string contains variables which aren't valid for whipper, raise ValueError exception listing all the included unrecognized variables.
I've also corrected the example template configuration lines in the README.

Fixes #279.
 2018-11-02 08:05:00 +00:00
JoeLametta
a011ca8d73 Update 'JoeLametta' to 'whipper-team' everywhere in repo 2018-11-02 08:00:00 +00:00
JoeLametta
30785b8d1b Push whipper v0.7.2 release 
🎃  🎃  🎃
 2018-10-31 08:00:00 +00:00
JoeLametta
24a0dceb71 Capitalize whipper's team name in README 2018-10-31 08:00:00 +00:00
JoeLametta
833cdb5de7 Merge pull request #318 from Freso/add-metainfo-xml-file 
Add AppStream metainfo.xml file
 2018-10-29 14:24:05 +00:00
JoeLametta
540703e6d5 Merge branch 'master' into add-metainfo-xml-file 2018-10-29 14:20:16 +00:00
JoeLametta
996cfd7bca Merge pull request #319 from Freso/issue-315-fix-unicode-error-in-truncate_filename 
Explicitly encode path as UTF-8 in truncate_filename()
 2018-10-29 12:28:18 +00:00
Frederik “Freso” S. Olesen
5e8d9117dd Add developer_name to .metainfo.xml file 
As per https://github.com/whipper-team/whipper/pull/318#issuecomment-433889475
 2018-10-29 13:27:48 +01:00
Frederik “Freso” S. Olesen
0fff37c954 Explicitly encode path as UTF-8 in truncate_filename() 
`os.pathconf()` expects a bytes object, but the path is stored as a
unicode object. Since there's no specified encoding, Python chokes when
trying to convert it to a bytes object. Explicitly encoding it as UTF-8
allows Python to change it to a bytes object smoothly.

Fixes https://github.com/whipper-team/whipper/issues/315
 2018-10-29 13:06:02 +01:00
Frederik “Freso” S. Olesen
43f3fbe818 Add initial AppStream metainfo.xml file 
AppStream metainfo.xml files are used to provide "metadata necessary for
an application-centric view on package repositories." This is an initial
and somewhat basic one written from scratch for whipper.

See https://www.freedesktop.org/wiki/Distributions/AppStream/
and https://www.freedesktop.org/software/appstream/docs/
 2018-10-28 17:55:28 +01:00
JoeLametta
f9cb126270 Update README's Docker part with Docker Hub info 
Now Docker adopters can use whipper trough Docker Hub's automatically built images.
Thanks to user "anarcat" for proposing and thoroughly explaining how to reach this goal.

Closes #301.
 2018-10-27 19:56:26 +02:00
JoeLametta
e33876c734 Fix flake8 W605 warning 2018-10-27 08:30:00 +00:00
JoeLametta
d25b995e28 Push whipper v0.7.1 release 2018-10-23 08:30:00 +00:00
JoeLametta
97052322cf Merge pull request #310 from whipper-team/requirements 
Add a requirements.txt file
 2018-10-23 09:39:50 +02:00
JoeLametta
fd6611743b Amend previous commit 
The comment included a typo and, using 'max' as variable name, I was accidentally shadowing Python's builtin 'max' function
 2018-10-23 08:00:00 +00:00
JoeLametta
a6d2e122e3 Add a requirements.txt file 
Fixes #221.
 2018-10-23 08:00:00 +00:00
JoeLametta
02fd962094 Limit length of filenames (#311) 
* Limit length of filenames

If whipper generated filenames are longer thant the maximum value supported by the filesystem, the I/O operations are going to fail.
With this commit filenames which may be too long are truncated to the maximum allowable length.

Fixes #197.
 2018-10-22 20:51:14 +02:00