benya/whipper-gui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,653 Commits 1 Branch 10 Tags
db36618628601fa679c2a77d1dfd686c7802663c
Commit Graph

155 Commits

Author SHA1 Message Date
Merlijn Wajer
656cbe1858 Merge pull request #634 from sinofp/fix-S 
Default %S to 'Unknown Artist'
 2026-02-07 14:21:05 +01:00
Merlijn Wajer
bf8fe39d6b Merge pull request #660 from CommandMC/feat/multiple-catalognums 
Support releases with multiple catalog numbers
 2026-02-07 12:41:23 +01:00
Merlijn Wajer
4bf9d8cf8b Merge pull request #662 from CommandMC/fix/releaseid-complete 
Make sure to always print out the full release id
 2026-02-07 10:59:26 +01:00
Katharina Dröge
d2f1ea9d9e Make sure to always print out the full release id 
Signed-off-by: Katharina Dröge <kate@commandmc.de>
 2025-09-25 23:45:55 +02:00
Katharina Dröge
65e9439d45 Support releases with multiple catalog numbers 
Signed-off-by: Katharina Dröge <kate@commandmc.de>
 2025-09-25 21:09:56 +02:00
Katharina Dröge
adab25986f No longer rely on pkg_resources 
Signed-off-by: Katharina Dröge <kate@commandmc.de>
 2025-09-24 21:52:02 +02:00
Merlijn Wajer
bc8b96d956 Merge pull request #549 from BioBox/prompt 
Better --prompt Handling
 2025-04-03 23:20:52 +02:00
sinofp
cac1fe5ed4 Default %S to 'Unknown Artist' 
When metadata is absent,
the %S template variable does not have a default value set in the dictionary,
which can cause a "KeyError: 'S'" error.

While %A defaults to 'Unknown Artist' and %S might conventionally default to 'Artist, Unknown',
defaulting %S to that is unnecessary,
because manual tagging typically follows to assign the correct name.
Therefore, I default %S to 'Unknown Artist', just like %A.

Signed-off-by: sinofp <sinofp@tuta.io>
 2024-08-30 23:09:06 +01:00
Joshua Simpson
098af47231 Save FLAC file after embedding cover art 
Signed-off-by: Josh Simpson <107582704+JoshWVS@users.noreply.github.com>
 2024-03-25 18:09:44 -04:00
JoeLametta
e0ad242795 Fix flake8 warning 
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2022-07-16 16:01:35 +00:00
Daniel J. Perry
3395c1d753 Make --prompt input case in-sensitive 
Signed-off-by: Daniel J. Perry <dperry45@gatech.edu>
 2021-08-01 14:29:14 -04:00
Daniel J. Perry
ebdbde4ce9 Less ambiguous prompt selection message 
Signed-off-by: Daniel J. Perry <dperry45@gatech.edu>
 2021-08-01 14:29:14 -04:00
Martin Weinelt
e0942417a1 Use custom YAML subclass to be compatible with ruamel_yaml>=0.17 
Signed-off-by: Martin Weinelt <hexa@darmstadt.ccc.de>
 2021-07-04 16:53:09 +02:00
JoeLametta
042bf8f926 Mark suitable methods as static 
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2021-05-26 10:35:58 +00:00
JoeLametta
06356fc40f README update, code linting changes 
- PEP8 fix
- Remove useless parens
- Docstring fixes
- RegEX: remove unneeded escape character
- accuraterip-checksum: output usage to stderr in case of wrong invocation

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2021-05-26 10:35:58 +00:00
JoeLametta
731453ea8d Avoid useless './' in file paths 
Replaced useless 'os.path.relpath(os.getcwd())' statement with 'os.curdir' (which is equal to '.').

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2021-05-16 17:19:14 +00:00
JoeLametta
9d67144087 Add 'TRACKTOTAL', 'DISCTOTAL', 'DISCNUMBER' metatada to audio tracks 
Co-authored-by: Máximo Castañeda <antiswen@yahoo.es>
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2021-05-16 10:32:02 +00:00
JoeLametta
1edd3657ba Introduce %M, %N template variables 
- %M: total number of discs in the chosen release
- %N: number of current disc

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2021-05-16 10:32:02 +00:00
JoeLametta
76b8004b8f Introduce %T (medium title) template variable 
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2021-05-16 10:32:02 +00:00
JoeLametta
e6ad23f119 Introduce %c (release disambiguation comment) template variable 
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2021-05-16 10:32:02 +00:00
JoeLametta
bff5c91fa3 Introduce %I (MusicBrainz Disc ID) template variable 
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2021-05-16 10:32:02 +00:00
JoeLametta
a97820b578 Add %D (disc title without disambiguation) to allowed template variables 
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2021-05-16 10:32:02 +00:00
JoeLametta
e4645dfdd3 Swap 'title' and 'releaseTitle' meaning 
- Trasparent change: now it makes more sense.
- Updated tests to reflect 'title', 'releaseTitle' meaning swap.
- Improved documentation.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2021-05-16 10:32:02 +00:00
JoeLametta
e6d9838148 Enable %B (barcode) and %C (catalog number) template variables 
Already included but were not allowed.
Improved documentation.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2021-05-16 10:32:02 +00:00
JoeLametta
0eaf80c4bb Template: replace None values with empty string 
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2021-05-16 10:28:54 +00:00
JoeLametta
dedd38f029 Ignore leading / trailing slashes in template 
Fixes #530.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2021-05-14 16:08:58 +00:00
JoeLametta
5040bc9094 Fix stupid syntax error in previous commit 
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2021-05-14 11:34:29 +00:00
JoeLametta
6577b7f262 Hopefully fix test failures introduced with previous commit 
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2021-05-14 11:25:41 +00:00
JoeLametta
7e30e7c952 Apply PathFilter's filters to all the template's components 
Fixes #513.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2021-05-14 10:33:38 +00:00
JoeLametta
1e33bc62ed Make PathFilter's filter tolerant to empty strings 
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2021-05-14 10:31:53 +00:00
blueblots
6505591462 Fixed m3u and cue sheet generation 
Added conditional to `program.write_m3u()` to
ignore skipped tracks.

Added skipped_tracks support to the `Program` and
`image.ImageVerifyTask` classes to avoid crashing
when a file for a skipped track doesn't exist.

Added conditional to `accurip.calculate_checksums`
to check if a path exists before trying to calculate
checksums, this prevents `accuraterip-checksum.c` from
emitting an error message (`sf_open failed!`) when a
path doesn't exist (as when a track is skipped).

Signed-off-by: blueblots <63152708+blueblots@users.noreply.github.com>
 2021-03-28 16:10:37 +00:00
Peter Taylor
4fb9d99ddd Add missing 'Album Artist' tag when its value is 'Various Artists' 
Fixes #518.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2020-12-25 14:30:00 +00:00
JoeLametta
c229c01a58 Replace 'freedb.dbpoweramp.com' CDDB server with gnudb.org 
It seems gnudb.org allows submissions too while 'freedb.dbpoweramp.com' is read only.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2020-11-28 17:44:21 +00:00
JoeLametta
3c9e75c3bc Merge pull request #509 from whipper-team/feature/issue-320-isrc-audio-tag 
Tag audio tracks with ISRCs (if available)
 2020-09-23 19:56:54 +02:00
JoeLametta
21185f40a9 Merge pull request #507 from whipper-team/bugfix/issue-385-missing-cd-warning 
Provide better error message when there's no CD in the drive
 2020-09-23 19:52:50 +02:00
JoeLametta
b754b2b0bf Restore getRipResult method to fix regression 
The regression was introduced in commit 3acc3ffed6.
The getRipResult method has been slimmed down to its essence.

Fixes #508.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2020-09-20 13:07:14 +00:00
JoeLametta
acf942b5b6 Tag audio tracks with ISRCs (if available) 
Fixes #320.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2020-09-19 20:14:22 +00:00
JoeLametta
921e25bf98 Provide better error message when there's no CD in the drive 
Fixes #385.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2020-09-17 19:18:27 +00:00
JoeLametta
3acc3ffed6 Drop whipper caching (#336) 
Whipper's caching implementation causes a few issues (#196, #230, [#321 (comment)](https://github.com/whipper-team/whipper/pull/321#issuecomment-437588821)) and complicates the code: it's better to drop this feature.

The rip resume feature doesn't work anymore: if possible it will be restored in the future.

* Remove caching item from TODO
* Delete unneeded files related to caching
* Update 'common/directory.py' & 'test/test_common_directory.py' (caching removal)
* Update 'common/accurip.py' & 'test/test_common_accurip.py' (caching removal)
* Update 'common/program.py' (caching removal)
* Update 'command/cd.py' (caching removal)

This fixes #335, fixes #196 and fixes #230.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2020-09-17 17:52:11 +02:00
JoeLametta
bbf1eba0e4 Replace 'freedb.freedb.org' CDDB server with a mirror 
This is motivated by the imminent shut down of freedb.org which will happen on 2020-03-31.

More details here: https://web.archive.org/web/20200331093822/http://www.freedb.org/
And here: https://hydrogenaud.io/index.php?topic=118682

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2020-03-31 13:22:21 +00:00
JoeLametta
4dc02ec12e Rewrite PathFilter 
Added filter options:
- dot (replace leading dot with _)
- posix (replace illegal chars in *nix OSes with _)
- vfat (replace illegal chars in VFAT filesystems with _)
- whitespace (replace all whitespace chars with _)
- printable (replace all non printable ASCII chars with _)

Removed filter options:
- fat (replaced with vfat)
- special

Fixes #313.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2020-02-22 18:01:20 +00:00
Andreas Oberritter
afc31f930e config: generalize getting and setting of drive options 
Fixed merge conflicts (JoeLametta).

Signed-off-by: Andreas Oberritter <obi@saftware.de>
 2020-02-22 16:15:25 +00:00
JoeLametta
e56c636fd3 Improve docstrings 
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2020-02-22 15:11:22 +00:00
JoeLametta
9e63915f65 Display release country in matching releases 
This simplifies choosing the correct release when there are multiple matches.
If a certain release has multiple countries associated, all will be shown.

Thanks to the user "the-confessor" for testing this new feature.

Fixes #451.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2020-02-04 16:36:02 +01:00
JoeLametta
3213241ea5 Merge pull request #461 from neilmayhew/fix/inline-config-comments 
Restore the ability to use inline comments in config files
 2020-02-04 16:23:55 +01:00
Neil Mayhew
dca9fcb7dc Restore the ability to use inline comments in config files 
The ability was lost in the switch to Python 3, because the config
parser module in the standard library changed its defaults.

[Python 2][2]:

> Comments may appear on their own in an otherwise empty line, or
> may be entered in lines holding values or section names.

[Python 3][3]:

> Inline comments can be harmful because they prevent users
> from using the delimiting characters as parts of values.
> That being said, this can be customized.

[2]: https://docs.python.org/2/library/configparser.html#module-ConfigParser
[3]: https://docs.python.org/3/library/configparser.html#supported-ini-file-structure

Signed-off-by: Neil Mayhew <neil@neil.mayhew.name>
 2020-02-03 15:01:36 -07:00
JoeLametta
87e75d0f98 Drop 'requests' external dependency 
It was only used in a single method and wasn't really needed.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2020-02-03 15:56:07 +00:00
JoeLametta
1a06e51c80 Add whipper useragent to AccurateRip requests 
Don't think it's required but it would be impolite not to announce
the software making the requests with its name, version and
contact information.

Fixes #439.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
 2020-01-29 14:58:09 +00:00
JoeLametta
087a53a7d0 Merge pull request #444 from ABCbum/add-alternative-tagging 
Add PERFORMER & COMPOSER metadata tags to audio tracks (if available)
 2020-01-29 10:01:27 +01:00
JoeLametta
7b8a20b22b Merge pull request #450 from ABCbum/develop 
Use https and http appropriately when connecting to MusicBrainz
 2020-01-29 10:00:35 +01:00