Mark suitable methods as static
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
This commit is contained in:
@@ -18,7 +18,8 @@ Example Disc ID: KnpGsLhvH.lPrNc1PBL21lb9Bg4-"""
|
||||
help="MusicBrainz Disc ID or Release ID to look up"
|
||||
)
|
||||
|
||||
def _printMetadata(self, md):
|
||||
@staticmethod
|
||||
def _printMetadata(md):
|
||||
"""
|
||||
Print out metadata received in a sensible way.
|
||||
|
||||
|
||||
@@ -103,7 +103,8 @@ class EmbedPictureTask(task.Task):
|
||||
task.Task.start(self, runner)
|
||||
self.schedule(0.0, self._embed_picture)
|
||||
|
||||
def _make_flac_picture(self, cover_art_filename):
|
||||
@staticmethod
|
||||
def _make_flac_picture(cover_art_filename):
|
||||
"""
|
||||
Given a path to a jpg/png file, return a FLAC picture for embedding.
|
||||
|
||||
|
||||
@@ -92,7 +92,8 @@ class Program:
|
||||
logger.info('changing to working directory %s', workingDirectory)
|
||||
os.chdir(workingDirectory)
|
||||
|
||||
def getFastToc(self, runner, device):
|
||||
@staticmethod
|
||||
def getFastToc(runner, device):
|
||||
"""
|
||||
Retrieve the normal TOC table from the drive.
|
||||
|
||||
@@ -507,7 +508,8 @@ class Program:
|
||||
stop = track.getIndex(1).absolute - 1
|
||||
return start, stop
|
||||
|
||||
def getCoverArt(self, path, release_id):
|
||||
@staticmethod
|
||||
def getCoverArt(path, release_id):
|
||||
"""
|
||||
Get cover art image from Cover Art Archive.
|
||||
|
||||
|
||||
@@ -30,13 +30,16 @@ class MockImageTable:
|
||||
MockImageTrack(2, 16264, 33487)
|
||||
]
|
||||
|
||||
def getCDDBDiscId(self):
|
||||
@staticmethod
|
||||
def getCDDBDiscId():
|
||||
return "c30bde0d"
|
||||
|
||||
def getMusicBrainzDiscId(self):
|
||||
@staticmethod
|
||||
def getMusicBrainzDiscId():
|
||||
return "eyjySLXGdKigAjY3_C0nbBmNUHc-"
|
||||
|
||||
def getMusicBrainzSubmitURL(self):
|
||||
@staticmethod
|
||||
def getMusicBrainzSubmitURL():
|
||||
return (
|
||||
"https://musicbrainz.org/cdtoc/attach?toc=1+13+228039+150+16414+"
|
||||
"33638+51378+69369+88891+104871+121645+138672+160748+178096+194680"
|
||||
|
||||
Reference in New Issue
Block a user