I left the "THOMAS" part in for now, but this seems more like a debug
message than a user facing message to me—but it was also obviously
something @thomasvs left in for himself, so maybe the whole if clause
has no reason to still be there and should just get removed.
Some of this seems to be debug code which has been left in, some of it
seems to just be old code that was commented out and never put back in
and probably just forgotten about. Either way, we use git for a reason,
so there's no need for these code snippets to stick around. The code
history can be inspected and old code retrieved that way.
Make MusicBrainz consistently written as "MusicBrainz" and not
"musicbrainz" or "Musicbrainz".
Doesn't change instances that refer to the Python module or similar.
A script that sets up an environment for running whipper without
actually installing it. With the clean ups that have happened to whipper
as well as later developments in the Python eco system, simply setting
up a virtualenv and running whipper from within that seems like a more
reasonable approach at this time.
This also fixes https://github.com/JoeLametta/whipper/issues/47 by
removing the "morituri-uninstalled mode" completely. :)
Not actually used by anything in the current codebase and PyChecker
doesn't seem to be the recommended Python code style checker or linting
tool currently. If we need a configuration file for another tool later
on, we can make one then based on current need and wants.
Was added in 2009 and not updated since. There are several Python
coverage tools out there, and the current ./COVERAGE doesn't seem to be
generated using this script either.
pep8.py was added in 2012. Since then, we now have flake8 and a number
of other really good PEP 8 (and other style, best practice, etc.) code
checkers/linters. It doesn't make sense to track this directly in the
repository. If we want to do automated code style/sanity checking, we
should add a dependency on an actually maintained program/script rather
than keeping it locally in the repository.
I'm going to tag this as a new amended version 0.5.1: no changes were done apart from the version number bugfix.
I've also included a code coverage report.
Fixes#147
If MusicBrainz returns data for the CD being ripped but no release date
is returned, we attempt to set the DATE tag to None (which is caught by
mutagen). To resolve this, check if there is a value for release date
before setting.
We can now rip CDs without gstreamer.
This is not the most clean attempt, but I have tried to remove most of the
code that depends on gstreamer. I hope there is not a lot of code left that
depends on code that I have removed - I can at least rip a CD fully.
* Add encoding using Xiph.org 'flac' program.
This adds a FlacEncodeTask that encodes wave files to flac files.
This commit also replaces morituri's EncodeTask with FlacEncodeTask, however, in
morituri, EncodeTask also does the tagging.
FlacEncodeTask will not perform the tagging.
So we will need an extra task for the tagging - this will be added soon.
Meanwhile, do not merge this commit to master yet.
* Add tagging using mutagen.
Replace the gstreamer tagging code with mutagen tagging code.
getTagList is rewritten to return a dictionary of tags, which are then simply
passed to mutagen.
The way it is set up right now is not the best - I don't think it makes sense
for tagging to take place in program/cdparanoia.py ; but this is how the current
code did it.
I suggest that, when we rip out all the gstreamer code, we also move the tagging
to a more sensible place; and then also make the tagging not be an actual
'task.Task'.
* Add gstreamer-less CRC32 version
Only works on wave files at this point. Should not be a problem, I think.
* Use proper musicbrainz tags and ALBUM tag.
* Add mutagen to .travis.yml
