Commit Graph

197 Commits

Author SHA1 Message Date
JoeLametta
adf4b79a20 Bump whipper version number to 0.4.1
Fixes #105
2017-01-07 23:53:47 +01:00
Matt Robinson
3f9cc77e30 Persist False value for defeat_cache correctly
If cdparanoia can't work around the audio caching of a drive,
defeats_cache = False is written to the config.  However, when it is
read back the string 'False' ends up being converted to True (as it is
not an empty string).

This corrects the behaviour when reading the value back and adds tests
to make sure that both True and False can be correctly retrieved from
the config.
2016-12-31 17:48:21 +00:00
Samantha Baldwin
976e1bdca2 remove configure.configure, use __version__, remove getRevision() (#94)
* remove configure.configure, use __version__, remove getRevision()

* remove empty configure/ directory

* remove morituri.configure imports
2016-12-31 16:41:18 +01:00
Samantha Baldwin
d1ed80d62a argparse & logging (#92)
* introduce logcommand.Lager, Whipper(); use argparse for whipper image commands, stub logging

* update Lager docstring to mention config.Config()

* make incorrect subcommand and --version work on toplevel command

* migrate accurip show, expand Lager, do not attempt to return from Lager.__init__.

* migrate offset find, add Lager.error

* correct offset find drive symlink handling

* migrate drive

* change Lager.__init__(prog) to arg from kwarg

* but actually

* remove Whipper.usage

* add and use Lager.device_option() context manager

* help I married an axe murderer

* use unified options namespace for entire command tree

* migrate whipper cd without comprehensive config loading

* switch to logging module

- use logging instead of flog for non-extern modules
- use WHIPPER_DEBUG and WHIPPER_LOGFILE env variables

* convert self.log calls to logger.debug

* convert self.error calls to logger.error

* remove log.Loggable, use logger not logging

* Logging conversion continues

- Convert log.* calls to logger.*
- Remove morituri.common.log imports

* remove morituri.common.log from tests

* remove extern/flog, bare minimum Debug conversion

* update README for logging changes

* update soxi to use logging

* refactor Lager for more declarative subcommands

* Refactor Lager.device_option:

- inline into __init__
- throw IOError instead of Exception for missing drives
- remove CommandError checking in rip/main

* rename rip to whipper in rip.main

* convert rip.debug commands

* Rename logcommand.Lager to command.BaseCommand

- remove command.CommandError occurrences
- remove python-command external module

* remove submodules from README, update rclog formatter

* update minor ambiguity in readme for command invocation

* update version number to match setup.py

* remove gitmodules

* update version number in tests as well (boo)

* convert logger.error to logger.critical

* Change morituri.rip to morituri.command

- mv common.command to command.basecommand
- move TEMPLATES used only by rip.cd out of rip.common
- update entry point for command to command.main

* update basecommand documentation

* go pyflaking: import fixing

* replace self.stdout with sys.stdout

* remove BaseCommand.config, alphabetise imports

* convert self.stdXXX leftovers

* convert last getRootCommand to config.Config

* convert last getExceptionMessage's to str

* change musicbrainz useragent to whipper
2016-12-20 23:11:30 +01:00
chrysn
bacda81408 AudioLengthTest: adapt to new soxi backend
* Use extensions soxi understands (ie. ".flac")
* Actually test for result correctness on files with odd characters in
  their names by copying the test track
* Relax the requirements on the "track absent" task to only raise some
  TaskError (the previously tested behavior was backend dependent, and
  the application did not actually depend on that behavior)
2016-11-29 12:56:18 +01:00
chrysn
89d6c8fef8 AudioLengthPath: move unit test in parallel to code 2016-11-29 12:56:18 +01:00
Samantha Baldwin
bccba71b42 refactor morituri.common.directory to shed Directory() and bulk 2016-11-02 17:52:14 -04:00
Samantha Baldwin
d7f8557426 replace cdrdao.py with much simpler version (#52)
* replace cdrdao.py with much simpler version
* more pythonic syntax for cdrdao.read_toc(fast_toc=) switching
* fix silly typo
2016-10-22 10:32:18 +02:00
Samantha Baldwin
8721ba1caf standardise program/sox.py formatting, add test case, docstring (#53)
* standardise program/sox.py formatting, add test case
* add program/sox.peak_level() docstring
* update .travis.yml to include sox as a test dependency
* move sox from test dependency to normal dependency
* update README to mention sox, remove small autoconf mention
* use .splitlines() instead of .split('n')
2016-10-21 23:54:13 +02:00
Samantha Baldwin
566414c939 nuke-autohell (#54)
* remove m4 directory
* remove leftover Makefile.am after confirming its uselessness
* remove another useless autoconf Makefile.am
2016-10-21 11:33:05 +02:00
JoeLametta
4636c55233 Update CI tests
* slightly updated the README file
* updated morituri version number in cue tests
* commented out a portion of testAccurateRipChecksum (it should be updated/fixed later on)
2016-10-20 09:57:05 +02:00
JoeLametta
746dc6599d Issue24 (#42)
* Address issue #24
* Remove getReadCaches() & replace it with getCache()

Now whipper always follows XDG specifications. All changes were documented into the README file.

The changes introduced here aren't backward compatible so, after updating whipper, you may need to configure it again (old config file are retained, though).
2016-10-09 17:26:06 +02:00
JoeLametta
84c2d2439c Commented out broken tests 2016-08-17 00:30:21 +02:00
JoeLametta
cd1505cb96 Update tests according to Travis CI 2015-12-12 11:42:45 +01:00
JoeLametta
3eb22ca1f5 Update two tests
Fix the two new tests failing because of
JoeLametta/whipper@ed4c9f4ece

JoeLametta/whipper#8
2015-12-12 11:13:24 +01:00
Frederik "Freso" S. Olesen
7bf7554e8c Resolve musicbrainz.org/doc/ redirect. 2014-11-02 11:18:35 +01:00
Frederik "Freso" S. Olesen
d81dd339c1 Resolve musicbrainz.org/{bare/cdlookup.html -> cdtoc/attach} redirect. 2014-11-02 11:17:51 +01:00
Frederik "Freso" S. Olesen
926ce46c8d Use HTTPS for musicbrainz.org. 2014-11-02 03:03:13 +01:00
Frederik "Freso" S. Olesen
f08d0a28ca Remove traces of mm.musicbrainz.org.
See
http://chatlogs.musicbrainz.org/musicbrainz-devel/2014/2014-11/2014-11-02.html#T01-18-50-32205
2014-11-02 03:01:38 +01:00
Thomas Vander Stichele
16ec35cf2f update release notes; include missing file for test 2014-07-15 23:15:57 -04:00
Thomas Vander Stichele
5142991c0c fix one more test 2014-05-26 15:56:46 -04:00
Thomas Vander Stichele
5b0ca8526d read cue and substitute current version to make tests pass 2014-05-26 15:39:58 -04:00
Thomas Vander Stichele
02ae3d5bfd add content to an older test 2013-11-23 16:01:20 -05:00
Thomas Vander Stichele
19fa97e23a use more diffstrings; use it from reference to generated 2013-08-24 13:57:56 +02:00
Thomas Vander Stichele
ea9225a9de now that we have a literal conversion of the toc, update
the toc doesn't notice the real pregap audio data, so marks the HTOA
as silence, and puts all following audio data in one file.

Update .cue file to reflect this; ie, create a cue file that misses the
HTOA
2013-08-24 02:41:01 +02:00
Thomas Vander Stichele
9f2ff9ee52 fix expectations on surfer rosa test
looks like it was interpreting relative on an index02 relative to the
track's index 00, instead of relative to the source
2013-08-24 02:41:00 +02:00
Thomas Vander Stichele
bf3db822dd strokes test case is now correct 2013-08-24 02:41:00 +02:00
Thomas Vander Stichele
a1e787648e add more tests, after calculating expected values for this disc 2013-08-24 02:40:20 +02:00
Thomas Vander Stichele
1ef45c2b2a stop absolutizing 2013-08-24 02:40:20 +02:00
Thomas Vander Stichele
e3e3a87547 WIP: try to set relative offset correctly based on sources 2013-08-24 02:40:20 +02:00
Thomas Vander Stichele
d1940b639f update tests 2013-08-24 02:38:39 +02:00
Thomas Vander Stichele
1ac8d43f88 use diffStrings 2013-08-24 02:38:39 +02:00
Thomas Vander Stichele
16bdaac89e add all EAC cue files for surfer rosa 2013-08-24 02:38:39 +02:00
Thomas Vander Stichele
a8fe47f1bd compare output .cue with EAC one we add
The EAC one clearly marks the HTOA of one frame as pre-gap, while we
don't yet do that.
2013-08-24 02:38:39 +02:00
Thomas Vander Stichele
f30b8b598f add more asserts on the current code for strokes
this shows that some of the logic may be wrong; track 1 index 1
should have relative 0 as it draws from the file, not silence
2013-08-24 02:38:39 +02:00
Thomas Vander Stichele
debd48d3e6 Add testcase to show that previous commit fixes #19. 2013-07-30 13:37:32 +02:00
Thomas Vander Stichele
7c95e8e017 Set proper track ids. Fixes #34 2013-07-30 13:23:34 +02:00
Thomas Vander Stichele
e5b2627db2 add more FIXME 2013-07-30 13:16:15 +02:00
Thomas Vander Stichele
ead648feef add getIds and use it to set correct ids 2013-07-30 13:09:56 +02:00
Thomas Vander Stichele
a8ef4a54c4 make sure sortname contains all artists 2013-07-30 13:07:09 +02:00
Thomas Vander Stichele
3d53056573 Extract a Credit list subclass to get name/sortname/id 2013-07-30 13:06:02 +02:00
Thomas Vander Stichele
7533b269fc add another test to fix 2013-07-30 12:47:00 +02:00
Thomas Vander Stichele
321f871805 add a test case to fix 2013-07-30 12:35:23 +02:00
Thomas Vander Stichele
430ee02a71 put space before colon 2013-07-29 12:29:47 +02:00
Thomas Vander Stichele
064c22e9e7 add test for directory module 2013-07-14 09:28:41 +02:00
Thomas Vander Stichele
34d58e2b5c more filtering 2013-07-13 22:46:20 +02:00
Thomas Vander Stichele
e29fa0fb18 fix a failing test 2013-07-13 18:49:00 +02:00
Thomas Vander Stichele
c75f71ead3 Add path filter 2013-07-13 18:38:31 +02:00
Thomas Vander Stichele
f93390d1bc pass config to program 2013-07-13 18:37:10 +02:00
thomasvs
eba184e54b Merge pull request #21 from supermanvelo/master
break up logger line; handle encoding for diff
2013-07-13 08:31:42 -07:00