make sure sortname contains all artists
This commit is contained in:
@@ -127,7 +127,7 @@ class _Credit(list):
|
||||
|
||||
|
||||
def getSortName(self):
|
||||
return self.joiner(lambda i: i.get('sort-name'))
|
||||
return self.joiner(lambda i: i.get('artist').get('sort-name', None))
|
||||
|
||||
def getName(self):
|
||||
return self.joiner(lambda i: i.get('artist').get('name', None))
|
||||
@@ -172,7 +172,7 @@ def _getMetadata(releaseShort, release, discid):
|
||||
|
||||
# getUniqueName gets disambiguating names like Muse (UK rock band)
|
||||
discMD.artist = albumArtistName
|
||||
discMD.sortName = discArtist['sort-name']
|
||||
discMD.sortName = credit.getSortName()
|
||||
# FIXME: is format str ?
|
||||
if not 'date' in release:
|
||||
log.warning('mbngs', 'Release %r does not have date', release)
|
||||
|
||||
@@ -62,8 +62,8 @@ class MetadataTestCase(unittest.TestCase):
|
||||
metadata = mbngs._getMetadata({}, response['release'], discid)
|
||||
|
||||
self.assertEquals(metadata.artist, u'Isobel Campbell & Mark Lanegan')
|
||||
# FIXME: this should include Mark
|
||||
self.assertEquals(metadata.sortName, u'Campbell, Isobel')
|
||||
self.assertEquals(metadata.sortName,
|
||||
u'Campbell, Isobel & Lanegan, Mark')
|
||||
self.assertEquals(metadata.release, u'2006-01-30')
|
||||
# FIXME: this is only Isobel
|
||||
self.assertEquals(metadata.mbidArtist,
|
||||
|
||||
Reference in New Issue
Block a user