Commit Graph

18 Commits

Author SHA1 Message Date
Samantha Baldwin
d1ed80d62a argparse & logging (#92)
* introduce logcommand.Lager, Whipper(); use argparse for whipper image commands, stub logging

* update Lager docstring to mention config.Config()

* make incorrect subcommand and --version work on toplevel command

* migrate accurip show, expand Lager, do not attempt to return from Lager.__init__.

* migrate offset find, add Lager.error

* correct offset find drive symlink handling

* migrate drive

* change Lager.__init__(prog) to arg from kwarg

* but actually

* remove Whipper.usage

* add and use Lager.device_option() context manager

* help I married an axe murderer

* use unified options namespace for entire command tree

* migrate whipper cd without comprehensive config loading

* switch to logging module

- use logging instead of flog for non-extern modules
- use WHIPPER_DEBUG and WHIPPER_LOGFILE env variables

* convert self.log calls to logger.debug

* convert self.error calls to logger.error

* remove log.Loggable, use logger not logging

* Logging conversion continues

- Convert log.* calls to logger.*
- Remove morituri.common.log imports

* remove morituri.common.log from tests

* remove extern/flog, bare minimum Debug conversion

* update README for logging changes

* update soxi to use logging

* refactor Lager for more declarative subcommands

* Refactor Lager.device_option:

- inline into __init__
- throw IOError instead of Exception for missing drives
- remove CommandError checking in rip/main

* rename rip to whipper in rip.main

* convert rip.debug commands

* Rename logcommand.Lager to command.BaseCommand

- remove command.CommandError occurrences
- remove python-command external module

* remove submodules from README, update rclog formatter

* update minor ambiguity in readme for command invocation

* update version number to match setup.py

* remove gitmodules

* update version number in tests as well (boo)

* convert logger.error to logger.critical

* Change morituri.rip to morituri.command

- mv common.command to command.basecommand
- move TEMPLATES used only by rip.cd out of rip.common
- update entry point for command to command.main

* update basecommand documentation

* go pyflaking: import fixing

* replace self.stdout with sys.stdout

* remove BaseCommand.config, alphabetise imports

* convert self.stdXXX leftovers

* convert last getRootCommand to config.Config

* convert last getExceptionMessage's to str

* change musicbrainz useragent to whipper
2016-12-20 23:11:30 +01:00
JoeLametta
0a142036ef Improve musicbrainzngs' results handling
Changes:

* whipper is now capable of handling musicbrainzngs’ bad server
responses (it throws an exception).
* whipper is now aware of musicbrainzngs’ possible “cdstub” response
and should handle it fine (ignoring the result because the informations
received are incomplete e/o unverified).

This commit should fix JoeLametta/whipper#22
2016-06-14 22:42:09 +02:00
JoeLametta
29bcd70b2b Fix musicbrainz-update branch merged pull request
Hopefully this commit fixes JoeLametta/whipper#16
2016-01-12 15:03:48 +01:00
Alexei
8f2158f26a Fixed more references 2015-12-12 10:51:22 -08:00
Alexei
c7b8f95323 Removed mentions of old musicbrainz ngs directory 2015-12-12 10:45:49 -08:00
JoeLametta
735596c401 Improve MusicBrainz results filtering
thomasvs/morituri#140
2015-11-29 16:26:49 +01:00
Frederik "Freso" S. Olesen
926ce46c8d Use HTTPS for musicbrainz.org. 2014-11-02 03:03:13 +01:00
Thomas Vander Stichele
debd48d3e6 Add testcase to show that previous commit fixes #19. 2013-07-30 13:37:32 +02:00
Thomas Vander Stichele
6eda5d7dc5 remove one if path 2013-07-30 13:25:28 +02:00
Thomas Vander Stichele
7c95e8e017 Set proper track ids. Fixes #34 2013-07-30 13:23:34 +02:00
Thomas Vander Stichele
e8d06ba3f1 distinguish between disc and track credit 2013-07-30 13:17:32 +02:00
Thomas Vander Stichele
ead648feef add getIds and use it to set correct ids 2013-07-30 13:09:56 +02:00
Thomas Vander Stichele
a8ef4a54c4 make sure sortname contains all artists 2013-07-30 13:07:09 +02:00
Thomas Vander Stichele
3d53056573 Extract a Credit list subclass to get name/sortname/id 2013-07-30 13:06:02 +02:00
Thomas Vander Stichele
7b17955664 add doc 2013-07-30 13:05:09 +02:00
Thomas Vander Stichele
6db23603ab rename to discArtist to disambiguate 2013-07-30 12:34:33 +02:00
Thomas Vander Stichele
d88d9f9bc6 rename metadata to discMD to be clearer 2013-07-30 11:39:40 +02:00
Thomas Vander Stichele
ee99d833a7 rename our musicbrainzngs.py to mbngs.py
Helps Debian package which prefers to strip out our copy of
musicbrainzngs
2013-03-05 16:12:52 +01:00