Commit Graph

1278 Commits

Author SHA1 Message Date
JoeLametta
8b5e8a66d6 Merge pull request #305 from anarcat/docker-order
Reorder Dockerfile for performance
2018-10-06 16:41:54 +00:00
Antoine Beaupré
dad3b6e379 reorder Dockerfile for performance
it's better to install/build whipper at the end of the Dockerfile,
because it will allow us to cache costly operations like locale-gen
while rebuilding with new source changes.
2018-10-05 12:03:31 -04:00
anarcat
6d7e54f8b2 Fix Docker invocation (#300)
* fix syntax error in Dockerfile

* fix Docker invocation

It makes no sense to pass the `-t` argument twice and we need to tell
Docker where to find the Dockerfile. Also, it makes sense to write the
config file in a standard location. In my tests, I also had to create
the directory by hand otherwise I got this error:

    cdparanoia can defeat the audio cache on this drive.
    Adding drive cache behaviour to configuration file.
    Traceback (most recent call last):
      File "/usr/local/bin/whipper", line 11, in <module>
        load_entry_point('whipper==0.7.0', 'console_scripts', 'whipper')()
      File "/usr/local/lib/python2.7/dist-packages/whipper-0.7.0-py2.7.egg/whipper/command/main.py", line 36, in main
        ret = cmd.do()
      File "/usr/local/lib/python2.7/dist-packages/whipper-0.7.0-py2.7.egg/whipper/command/basecommand.py", line 139, in do
        return self.cmd.do()
      File "/usr/local/lib/python2.7/dist-packages/whipper-0.7.0-py2.7.egg/whipper/command/basecommand.py", line 139, in do
        return self.cmd.do()
      File "/usr/local/lib/python2.7/dist-packages/whipper-0.7.0-py2.7.egg/whipper/command/drive.py", line 63, in do
        info[0], info[1], info[2], t.defeatsCache)
      File "/usr/local/lib/python2.7/dist-packages/whipper-0.7.0-py2.7.egg/whipper/common/config.py", line 115, in setDefeatsCache
        section = self._findOrCreateDriveSection(vendor, model, release)
      File "/usr/local/lib/python2.7/dist-packages/whipper-0.7.0-py2.7.egg/whipper/common/config.py", line 164, in _findOrCreateDriveSection
        self.write()
      File "/usr/local/lib/python2.7/dist-packages/whipper-0.7.0-py2.7.egg/whipper/common/config.py", line 58, in write
        shutil.move(path, self._path)
      File "/usr/lib/python2.7/shutil.py", line 316, in move
        copy2(src, real_dst)
      File "/usr/lib/python2.7/shutil.py", line 144, in copy2
        copyfile(src, dst)
      File "/usr/lib/python2.7/shutil.py", line 97, in copyfile
        with open(dst, 'wb') as fdst:
    IOError: [Errno 13] Permission denied: u'/home/worker/.config/whipper/whipper.conf'

* remove needless tag version

:latest is implicit so it's useless noise as well.

* Update README.md
2018-10-03 15:43:58 +00:00
Thomas McWork
cfcbfd5623 Document Docker usage in the README (#297)
Document Docker usage in the README
2018-10-03 08:07:47 +00:00
JoeLametta
777b12934c Empty test commit 2018-09-25 08:00:00 +00:00
Thomas McWork
0a762e23b8 Add Dockerfile (#237)
* add dockerfile

* add cleanup and reduce produces layers

* switch to pycdio==0.21 + libcdio manual build

* use libcdio 2.0.0 and pycdio 2.0.0
2018-09-24 21:19:08 +00:00
Andreas Oberritter
542e071443 switch CDDB implementation to freedb.py from python-audio-tools (#276)
* freedb: Import from python-audio-tools 660ee2c

License: GPL-2.0+

* freedb: Remove unused code and set client name to whipper.

The removed functions depend on other classes of python-audio-tools,
but aren't needed here.

* cddb-py: replace with newer freedb implementation

The last release of cddb-py was 15 years ago. The freedb code taken
from python-audio-tools speaks protocol version 6 (Unicode) and is
compatible to both Python 2 and 3.

* freedb: Don't allow the pedantic CI test to fail
2018-06-08 14:40:56 +00:00
Joe
84fa7c0944 Merge pull request #268 from JoeLametta/python3
Incremental code modernization for (future) Python 3 port
2018-06-08 14:34:41 +00:00
Joe
241f44eff6 Merge branch 'master' into python3 2018-06-08 14:32:27 +00:00
Joe
5db7656ef8 Clarify pre-emphasis reporting implementation
Currently whipper only reports about the pre-emphasis flag value as stored in the TOC.

Related to #275.
2018-05-24 17:29:51 +02:00
Joe
a320f6a0a5 Remove whipper's image retag feature (#269)
Fixes #262.
2018-05-24 17:19:14 +02:00
Andreas Oberritter
145403705d Switch to PyGObject by default (#271)
* cd/offset: remove unused call to gobject.thread_init()

There are no threads involved.

* task: switch to PyGObject

Python-gobject-2 is deprecated.

* travis: update dependencies for PyGObject and GLib-2.0

* README: Add GObject Introspection
2018-05-24 17:11:37 +02:00
Joe
8fe47ede2b Merge pull request #272 from mtdcr/task-log
task: implement logging
2018-05-24 11:12:58 +02:00
Andreas Oberritter
a5e3b0d325 task: implement logging 2018-05-10 03:48:46 +02:00
JoeLametta
3916f03e07 Indexing exceptions will not work on Python 3 2018-05-08 18:39:08 +02:00
JoeLametta
71df9124a6 Fix dict.keys referenced when not iterating 2018-05-08 18:39:08 +02:00
JoeLametta
f6d9f398b0 Exception.message removed in Python 3 2018-05-08 18:39:08 +02:00
JoeLametta
0f67bc4a96 Remove unneeded brackets in print statements 2018-05-08 18:39:08 +02:00
JoeLametta
bd81f80afa Make flake8 happy 2018-05-08 18:39:08 +02:00
JoeLametta
2b4140d300 Make Python code more idiomatic 2018-05-08 18:39:08 +02:00
JoeLametta
a484815106 Fix dictionary iteration methods 2018-05-08 18:39:08 +02:00
JoeLametta
b6ac79f01e Wrap map() in a list call 2018-05-08 18:39:08 +02:00
JoeLametta
9a7511b952 Replace iterator's next() methods usage with the next() function 2018-05-08 18:39:08 +02:00
JoeLametta
c26d4e99e5 Convert octal literals into the new syntax 2018-05-08 18:39:08 +02:00
JoeLametta
d3522940b2 Wrap existing range() calls with list 2018-05-08 18:39:08 +02:00
JoeLametta
7dff041362 Replace filter calls with list comprehensions 2018-05-08 18:39:08 +02:00
JoeLametta
4280dbfafc Convert except X, T to except X as T 2018-05-08 18:39:08 +02:00
JoeLametta
5f75d41c7b Replace deprecated unittest method names with the correct ones 2018-05-08 18:39:08 +02:00
JoeLametta
44ece38740 In Python 3 print is a function 2018-05-08 18:39:08 +02:00
JoeLametta
37fd1c6bb2 Add cdparanoia version to log file
Fixes #267.
2018-05-08 12:00:00 +00:00
JoeLametta
99bfe41c0a Update Travis CI URL 2018-05-08 08:00:00 +00:00
Joe
eb16904b9e Merge pull request #264 from mtdcr/master
Remove dead code from program.getFastToc
2018-05-08 08:46:32 +02:00
Andreas Oberritter
732515723e Remove dead code from program.getFastToc
The caching mechanism didn's have any effect. The inline function
'function' wasn't used anymore.
2018-05-07 20:02:36 +02:00
JoeLametta
db8050d8c4 Fix PEP-8 E128 2018-04-09 08:05:00 +00:00
JoeLametta
b5caf86cd2 Push whipper v0.7.0 release 2018-04-09 08:00:00 +00:00
Joe
1cece638cd Misc README changes
Fixes #229.
2018-04-09 10:31:04 +02:00
Q3CPMA
19eb9741c7 command.cd: simple message while reading toc
Fixes #257.
2018-04-05 18:00:00 +00:00
Samantha Baldwin
1ba0132948 Small readme cleanups (#250)
* README cleanups

	- remove backwards incompatible changes section
	- add note about adding and running tests for devs
	- remove mention of incomplete man page
	- remove mention of force-pushed non-master branches

* README: one line per shield

* README: table of content updates

* README: remove Credits

* Revert "README: remove Credits"

This reverts commit f2b126c737595e08f4500ea284c8e69b457550cb.
2018-03-22 14:28:32 +01:00
Samantha Baldwin
574b8b2ea5 Remove debug commands, add mblookup command (#249)
* add mblookup command

* remove debug commands

* mblookup: replace sys.stdout.write with print

* minor formatting fixes
2018-03-22 14:27:18 +01:00
Samantha Baldwin
fd2c56053b read command parameters from config sections (#240)
* read command parameters from config sections

* README: update config file documentation

* README: config example type INI, add comma

* README: clearer and better spelled wording

* README: fix 'delineated' typo
2018-03-07 14:39:29 +01:00
Joe
f6169ae3cb State that whipper isn't just a fork of morituri
First step for #79.
2018-03-03 11:37:08 +01:00
Joe
7b5af61459 Merge pull request #246 from RecursiveForest/un-rst
Revert "Convert docstrings to reStructuredText"
2018-03-03 11:15:18 +01:00
Joe
abe163dd95 Merge pull request #248 from mruszczyk/master
Remove reference to Copr repository
2018-03-03 11:14:21 +01:00
Samantha Baldwin
09de58852e Revert "Convert docstrings to reStructuredText"
This reverts commit 3b1bd242d0.
2018-03-02 16:47:12 -05:00
Matthew Ruszczyk
3a7e17f388 Remove references to Copr repository
Whipper is now available from the official Fedora repositories so mentions to the Copr are no longer required.
2018-03-02 14:18:14 -05:00
Joe
f8fbfb591c Merge pull request #245 from RecursiveForest/remove-toc-pickle
remove -T/--toc-pickle
2018-03-02 17:23:33 +01:00
Joe
e0cec118a3 Merge pull request #242 from RecursiveForest/remove-radon
remove radon reports
2018-03-02 17:00:19 +01:00
Joe
b07f37ec7c Merge pull request #243 from RecursiveForest/copyright-holders
credit four major developers by line count
2018-03-02 16:57:54 +01:00
Samantha Baldwin
44e160910c remove -T/--toc-pickle 2018-03-01 21:14:15 -05:00
Samantha Baldwin
c7e8a0f21d credit four major developers by line count 2018-03-01 20:48:29 -05:00