benya/whipper-gui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,200 Commits 1 Branch 10 Tags
75a3d4bce173b6c37ca7674f6c3f05b4bd852a8f
Commit Graph

1200 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
JoeLametta
75a3d4bce1 Fix two PEP8 errors 2018-01-04 20:58:00 +01:00
Joe
1247c94e8c Merge pull request #195 from RecursiveForest/restore-flac-extension 
restore .flac extension
 2017-11-06 09:16:13 +01:00
Joe
fef437f93e Remove redundant error reporting line 
Fixes #198.
 2017-10-08 22:38:51 +02:00
Joe
f54c4bb040 Merge pull request #199 from LingMan/patch-1 
Fix recently introduced Python 3 incompatibility
 2017-10-08 22:22:12 +02:00
LingMan
d97371dbc7 Fix recently introduced Python 3 incompatibility 
Fixes d4aad57188
 2017-09-30 02:52:11 +02:00
Samantha Baldwin
00169792d7 restore .flac extension 2017-09-19 14:27:28 -04:00
JoeLametta
a3e92606c5 Merge pull request #187 from RecursiveForest/rewrite-accuraterip 
AccurateRip V2 support
 2017-09-15 23:12:40 +02:00
Samantha Baldwin
d4aad57188 fix minor string handling minibugs 2017-09-15 16:10:22 -04:00
gorgobacka
7ae27de32b Fix artist name (#156) 
* Use artist-credit->name

Use artist-credit->name, if it exists. Otherwise use artist-credit->artist->name.

* Add test case

* Fix for PEP8

* transform comment to docstring

* reject 'recording artist name' in favour of 'release artist name'

* reject 'recording artist name' in favour of 'release artist name'
 2017-09-14 22:25:28 +02:00
Samantha Baldwin
d6424374a8 program.py: more robust write_m3u() 2017-09-11 18:52:23 -04:00
Samantha Baldwin
311084c4fd offset.py: handle accurip response not found 2017-09-10 22:47:08 -04:00
Samantha Baldwin
94b9a1bbf6 fix image verify: 
- accurip.py: raise exception if accuraterip db entry not found
- program.py: verify image with only one table, remove redundant check
 2017-09-10 22:35:10 -04:00
Samantha Baldwin
b98cc32fd0 program.py: correct m3u htoa handling 2017-09-10 21:53:08 -04:00
Samantha Baldwin
a482c86832 potentially fix UnicodeEncodeError 2017-09-09 16:04:58 -04:00
Samantha Baldwin
b936aff000 fix htoa getPath bug 2017-09-09 15:31:28 -04:00
Samantha Baldwin
e4ca5c0a7f fix bare raise, fix fencepost error 2017-09-09 15:12:00 -04:00
JoeLametta
158fab278f Merge pull request #188 from ubitux/misc-fixes 
Misc fixes
 2017-09-09 20:20:58 +02:00
Clément Bœsch
984dd524ef README: document developer installation as user 
If you're looking into running uninstalled, you likely don't want to
setup as root.
 2017-09-08 21:14:00 +02:00
Clément Bœsch
6938c506bb basecommand: use logger.critical() instead of sys.stderr.write() 
As a side effect, this fixes the missing trailing line break.
 2017-09-08 20:56:18 +02:00
Clément Bœsch
a7d70c6a56 cd: remove weird redundant "default default" help string 2017-09-08 19:54:49 +02:00
JoeLametta
47842c2d2a Update README.md 2017-09-08 14:11:00 +02:00
Samantha Baldwin
a72ae82f0d test_common_accurip: remove leftover line 2017-09-07 14:56:29 -04:00
Samantha Baldwin
47ca07e3a9 command/cd: remove vestigial exit under path check 2017-09-07 14:50:39 -04:00
Samantha Baldwin
4126ec5d2f command/accurip: use new accurip module 2017-09-07 14:50:05 -04:00
Samantha Baldwin
a124047af3 add requests dependency to README 2017-09-04 22:07:17 -04:00
Samantha Baldwin
83729ef7f3 deflake, remove morituri hack, more error handling 2017-09-04 21:55:05 -04:00
Samantha Baldwin
007dc0729e add Marduk - Hearse accuraterip db entry bin 2017-09-04 21:34:47 -04:00
Samantha Baldwin
7553151520 add requests to travis config 2017-09-04 21:31:58 -04:00
Samantha Baldwin
bfa0308880 AccurateRip V2 support 
- output path no longer has fallbacks
- refactor accuraterip cache
- use requests to download accuraterip entries
- add tests for accuraterip functionality
- remove gobject support from accuraterip-checksum calculation
- default track template now includes extension
- begin to remove support for continuing rip
- begin to use print instead of sys.stdout.write() throughout
 2017-09-04 21:26:34 -04:00
JoeLametta
3f248bfc00 Merge pull request #159 from sqozz/devision_zero 
Fix division by zero
 2017-08-02 10:26:20 +02:00
Sqozz
e84361b653 Fix division by zero 2017-07-28 18:27:42 +02:00
JoeLametta
af18471cba Fix failing unittest in systemd-nspawn 
Fixes #157
Only test_common_directory.py is changed because the other unittest is working as expected (the failure isn't related to whipper).
 2017-06-30 18:17:29 +02:00
JoeLametta
893139f683 Update README.md 
Fixes #152
Fixes #165
 2017-06-19 14:19:56 +02:00
gorgobacka
4b3d462b16 Detect and handle CD-R discs (#154) 
* Use cdrdao to detect CD-Rs and continue ripping only if the argument --cdr is passed.

* Get and display disc format from MusicBrainz.

* Add info about CD-R detection to logger

* Remove Musicbrainz medium format info

* add cdrdao command to logger

* Fix for PEP8

* Fix line break
 2017-06-06 11:12:00 +02:00
JoeLametta
fe4cf1a745 Merge pull request #153 from Freso/issue-127-always-disambiguate-on-release 
Disambiguate on release
 2017-06-05 13:28:02 +02:00
Frederik “Freso” S. Olesen
a0c0ce7e47 Fix(/ignore) PEP8/flake8 errors 2017-06-01 02:31:03 +02:00
Frederik “Freso” S. Olesen
5ba3e924fb Refactor Program.getPath disambiguation logic to .addDisambiguation 2017-05-31 23:33:07 +02:00
Frederik “Freso” S. Olesen
b0d047ded1 Add unittest for new Program.addDisambiguation() method 2017-05-31 23:33:07 +02:00
Frederik “Freso” S. Olesen
2465f03337 Add disambiguation to the end of template strings w/o "%d" 2017-05-31 23:33:07 +02:00
Frederik “Freso” S. Olesen
4512cd3919 Test that disambigation is added to templates without "%d" 2017-05-31 23:33:06 +02:00
Frederik “Freso” S. Olesen
e5f2afe0db Break out of disambiguation loop once disambig has been added 
Instead of iterating over all the path parts and added disambiguation to
each, it now only adds the disambiguation to the first match.
 2017-05-31 23:33:06 +02:00
Frederik “Freso” S. Olesen
f3e3748d75 Test that disambiguation is only added once 2017-05-31 23:33:06 +02:00
Frederik “Freso” S. Olesen
a14989583e Use regular str.split() to split template parts in disambiguation 
os.path.split() only even splits into two components, which means that
path templates that have more than two parts (e.g., `%A/%d - %y/%X`)
will not get split properly for the purpose of added disambiguation
parts to them.

os.path.join() will still work fine to splice the split template back
together as it takes an arbitrary number of arguments.
 2017-05-31 23:33:06 +02:00
Frederik “Freso” S. Olesen
12e52da55d Add more template test cases to testDisambiguateOnRelease 
Some of these might not occur in the wild, but we theoretically support
them at least, and making sure they work might catch other issues we
didn't think of yet.
 2017-05-31 23:33:06 +02:00
Frederik “Freso” S. Olesen
3f30f1d46f Always disambiguate in the release title part of the template 
Fixes https://github.com/JoeLametta/whipper/issues/127
 2017-05-31 23:31:15 +02:00
Frederik “Freso” S. Olesen
846ee04a5f Add test case illustrating https://github.com/JoeLametta/whipper/issues/127 2017-05-31 23:31:15 +02:00
JoeLametta
5e4303fdbf Merge pull request #160 from Freso/flake8-clean 
Stop allowing flake8 to fail in Travis CI
 2017-05-31 23:23:22 +02:00
Frederik “Freso” S. Olesen
dd6d1d0579 Stop allowing flake8 to fail in Travis CI 
Commit b6fb7e8a86 fixes all current flake8
errors, so unsetting this `allow_failures` makes sure that any PEP8 or
similar syntax mistakes get caught immediately.
 2017-05-31 23:14:54 +02:00
JoeLametta
b6fb7e8a86 Solve all flake8 warnings (#163) 
Whipper is now fully PEP8 compliant.
Revised version which includes all the changes suggested by Freso.
 2017-05-31 23:09:36 +02:00
JoeLametta
b331f53b47 Merge pull request #161 from Freso/minor-touchups 
Minor touchups
 2017-05-21 10:08:17 +02:00