Commit Graph

1434 Commits

Author SHA1 Message Date
JoeLametta
4238e714be Merge branch 'develop' 2019-10-27 13:30:33 +00:00
JoeLametta
db9c44a765 Push whipper v0.8.0 release
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-10-27 13:30:18 +00:00
JoeLametta
8e60fb9a18 Merge pull request #415 from itismadness/ruamel_yaml
Use ruamel.yaml for formatting and outputting rip .log file
2019-10-27 09:11:49 +01:00
itismadness
3cd2da79c3 write unit test case for WhipperLogger
Signed-off-by: itismadness <itismadness@users.noreply.github.com>
2019-10-27 08:00:00 +00:00
itismadness
862afffee9 Use ruamel.yaml for formatting rip .log file
- insert newlines after blocks of content
- strip quotes around creation time and offset
- Change offset value representation
- Clarify logger regular expressions
- Fix missing AccurateRip Summary field
- Read usage of time.gmtime(epoch) for generating datetime string
- fix missing dependency in travis
- install pycdio with specific version separately

Signed-off-by: itismadness <itismadness@users.noreply.github.com>
2019-10-27 08:00:00 +00:00
JoeLametta
81af7a4d03 Update Dockerfile
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-10-26 09:00:00 +00:00
JoeLametta
d7f6d6888f Merge pull request #274 from mtdcr/accuraterip-module
accuraterip-checksum: convert to python C extension
2019-10-26 11:32:27 +02:00
JoeLametta
da42842e58 Merge pull request #410 from whipper-team/bugfix/issue-375-cd-info-no-attribute
Handle missing self.options for whipper cd info
2019-10-26 11:29:07 +02:00
JoeLametta
993dd6cc33 Handle missing self.options for whipper cd info
The attributes working_directory, disc_template, output_directory and offset are not defined during whipper cd info and they are only needed for ripping. self.program.getTable doesn't need output_path to gather the tocfile.

Therefore, this part is excluded, if the attributes don't exist and an offset of 0 is used.

Fixes issue #375.

Co-authored-by: gorgobacka <tho.b.j@gmx.de>
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
Signed-off-by: gorgobacka <tho.b.j@gmx.de>
2019-10-26 11:24:30 +02:00
JoeLametta
d9b49df0aa Whitespace fixes
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-10-26 08:05:00 +00:00
JoeLametta
87a477a5d6 Fix wrong logger call
Introduced in 048a31e348.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-10-26 08:00:00 +00:00
JoeLametta
4569644335 Separate out Release in log into two value map
This allows log parsers to always extract correct information about the "artist" and "title" fields: previously that was a problem if either (or both) of those fields contained a "-" character.

Fixes #416.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-10-22 07:00:00 +00:00
JoeLametta
35561b51e5 Dockerfile: build newer libcdio version
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-10-21 16:30:00 +00:00
JoeLametta
948cde7921 Update README
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-10-21 16:00:00 +00:00
JoeLametta
8b6b2d34fe Merge pull request #418 from mtdcr/fix-less-than-ten
Fix ripping discs with less than ten tracks
2019-10-21 17:40:18 +02:00
JoeLametta
2e966a446d Pass toc_path as argument in program.py
Resolves #368.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-10-21 14:00:00 +00:00
JoeLametta
1be5adda65 Merge pull request #407 from whipper-team/bugfix/issue-284-flac-file-permissions
Set FLAC files permissions to 0644
2019-10-21 16:32:13 +02:00
JoeLametta
fe13affac2 Merge pull request #409 from whipper-team/bugfix/issue-361-drive-analysis-fails
Fix erroneous result message for whipper drive analyze
2019-10-21 16:30:03 +02:00
JoeLametta
14fb96e87c Merge pull request #408 from whipper-team/bugfix/issue-354-eliminate-eject-warning
Report eject's failures as logger warnings
2019-10-21 16:26:58 +02:00
JoeLametta
3b2b732516 Merge pull request #417 from mtdcr/fast-toc
Make getFastToc() fast again
2019-10-20 16:05:17 +02:00
Andreas Oberritter
abf9a971e7 Fix ripping discs with less than ten tracks
Output lines of cdrdao for single digit track numbers start with a
whitespace character.

Broken since #345 was merged.

Signed-off-by: Andreas Oberritter <obi@saftware.de>
2019-10-20 15:41:33 +02:00
Andreas Oberritter
342bce9be2 Make getFastToc() fast again.
Broken since #345 was merged.

Signed-off-by: Andreas Oberritter <obi@saftware.de>
2019-10-20 15:25:17 +02:00
Andreas Oberritter
252a2e8141 Use ittoc only for CDDB and MusicBrainz lookups
The data from itable may be more accurate, because ittoc comes from
getFastToc().

Signed-off-by: Andreas Oberritter <obi@saftware.de>
2019-10-20 15:25:17 +02:00
Andreas Oberritter
f68b91bc40 accuraterip-checksum: Add and install backwards-compatible script
Signed-off-by: Andreas Oberritter <obi@saftware.de>
2019-10-20 15:20:35 +02:00
Andreas Oberritter
ab95715efc accuraterip-checksum: convert to python C extension
* calculate v1 and v2 checksums at once
* let libsndfile handle both WAV and FLAC

Signed-off-by: Andreas Oberritter <obi@saftware.de>
2019-09-09 20:37:50 +02:00
JoeLametta
635113be9a Fix incorrect frames to MSF conversion
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-08-19 12:00:00 +00:00
JoeLametta
1c6fe42202 Set FLAC files permissions to 0644
Fixes #284.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-07-07 12:00:00 +00:00
JoeLametta
e5961ae04c Report eject's failures as logger warnings
If the eject command exits with an error, the output is logged as a WARNING. I don't think it's a good idea to mask those errors.

Closes #354.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-07-07 12:00:00 +00:00
JoeLametta
048a31e348 Fix erroneous result message for whipper drive analyze
If cdparanoia fails to analyze the drive, the drive is now marked as unable to defeat the cache.

Fixes #361.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-07-07 10:00:00 +00:00
JoeLametta
57d386e82f Remove too verbose logger statements
Related to #278.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-07-07 10:00:00 +00:00
it is madness
0d69258654 Use YAML 1.2 boolean values for booleans
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-07-06 16:00:00 +00:00
JoeLametta
b5f0af21be Merge pull request #406 from vmx/fix-offset-find
Fix offset find command
2019-07-05 11:18:49 +02:00
JoeLametta
4eeb0cddc7 Update failing AccurateRipResponse tests 2019-07-05 08:00:00 +00:00
Volker Mische
9cf890a6e2 Fix offset find command
The refactoring of `ReadTOCTask` in commit 3e79032b63
broke the `offset find` command. This commit fixes it again.

Signed-off-by: Volker Mische <volker.mische@gmail.com>
2019-07-05 00:06:02 +02:00
Thomas Vander Stichele
7a4680f285 Add testcase for Gentlemen: same CDDB ID as Interpol
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-05-09 09:46:28 +02:00
JoeLametta
3a74c60344 Update "required dependencies" section in README
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-05-04 10:18:03 +02:00
JoeLametta
bb78dc109d Merge pull request #387 from whipper-team/feature/issue-383-restructuredtext
Convert documentation from epydoc to reStructuredText
2019-05-03 20:11:09 +02:00
JoeLametta
69f8f39c49 Change documentation from epydoc to reStructuredText
Thanks to Freso for all the useful comments!

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-05-03 20:06:13 +02:00
JoeLametta
8db090c9bf Add Freso to whipper's credits
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-05-03 19:19:16 +02:00
JoeLametta
ccfe724e2e Merge pull request #392 from gorgobacka/default_success
Set default for eject to: success
2019-05-03 12:28:28 +02:00
JoeLametta
78b3c0d56a Merge pull request #391 from gorgobacka/perform_eject
Use eject value of the class again
2019-05-03 12:28:00 +02:00
gorgobacka
eff5fee3f4 use self.eject
Signed-off-by: gorgobacka <tho.b.j@gmx.de>
2019-05-03 12:25:48 +02:00
Frederik “Freso” S. Olesen
bb6a29c5df Update Travis config for Python specific handling
See the Python documentation for more information:
https://docs.travis-ci.com/user/languages/python/

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
2019-05-03 11:43:43 +02:00
JoeLametta
7a92650eff Update Docker Hub's repository URL
See #395.
2019-05-03 10:46:24 +02:00
JoeLametta
a9b6e3c91b Merge pull request #398 from whipper-team/bugfix/issue-396-no-mb-release-group-type
Make whipper not break on missing release type
2019-05-03 10:16:12 +02:00
Frederik “Freso” S. Olesen
bf8daf186d mbngs: Let releaseType be None if no type is set
Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
2019-05-03 02:49:42 +02:00
Frederik “Freso” S. Olesen
f74455c9f0 mblookup: Cast None to unicode before encoding
Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
2019-05-03 02:43:31 +02:00
Frederik “Freso” S. Olesen
c2459067ce Test mblookup output when release type is missing
Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
2019-05-03 02:38:38 +02:00
Frederik “Freso” S. Olesen
885ad172a8 Set release type to empty string if none is given
Fixes https://github.com/whipper-team/whipper/issues/396

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
2019-05-02 18:37:51 +02:00
Frederik “Freso” S. Olesen
8209927a79 Add testcase for failure when missing release type
See https://github.com/whipper-team/whipper/issues/396

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
2019-05-02 18:35:42 +02:00