benya/whipper-gui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mbngs: Let releaseType be None if no type is set

Browse Source 
Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
This commit is contained in:
Frederik “Freso” S. Olesen
2019-05-03 02:44:29 +02:00
parent f74455c9f0
commit bf8daf186d
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
whipper/common/mbngs.py
View File

@@ -184,8 +184,6 @@ def _getMetadata(release, discid, country=None):
if 'type' in release['release-group']: if 'type' in release['release-group']:
discMD.releaseType = release['release-group']['type'] discMD.releaseType = release['release-group']['type']
else:
discMD.releaseType = u''
discCredit = _Credit(release['artist-credit']) discCredit = _Credit(release['artist-credit'])
# FIXME: is there a better way to check for VA ? # FIXME: is there a better way to check for VA ?

2
whipper/test/test_common_mbngs.py
View File

@@ -219,7 +219,7 @@ class MetadataTestCase(unittest.TestCase):
discid = "xu338_M8WukSRi0J.KTlDoflB8Y-" # disc 4 discid = "xu338_M8WukSRi0J.KTlDoflB8Y-" # disc 4
metadata = mbngs._getMetadata(response['release'], discid) metadata = mbngs._getMetadata(response['release'], discid)
self.assertEqual(metadata.releaseType, u'') self.assertEqual(metadata.releaseType, None)
def testAllAvailableMetadata(self): def testAllAvailableMetadata(self):
"""Check that all possible metadata gets assigned.""" """Check that all possible metadata gets assigned."""