From bf8daf186db7dd75b6bb7052dc0f48534d70ef86 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Frederik=20=E2=80=9CFreso=E2=80=9D=20S=2E=20Olesen?= Date: Fri, 3 May 2019 02:44:29 +0200 Subject: [PATCH] mbngs: Let releaseType be None if no type is set MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Frederik “Freso” S. Olesen --- whipper/common/mbngs.py | 2 -- whipper/test/test_common_mbngs.py | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/whipper/common/mbngs.py b/whipper/common/mbngs.py index 7ded6aa..07223ee 100644 --- a/whipper/common/mbngs.py +++ b/whipper/common/mbngs.py @@ -184,8 +184,6 @@ def _getMetadata(release, discid, country=None): if 'type' in release['release-group']: discMD.releaseType = release['release-group']['type'] - else: - discMD.releaseType = u'' discCredit = _Credit(release['artist-credit']) # FIXME: is there a better way to check for VA ? diff --git a/whipper/test/test_common_mbngs.py b/whipper/test/test_common_mbngs.py index 5d2693c..6cc89d8 100644 --- a/whipper/test/test_common_mbngs.py +++ b/whipper/test/test_common_mbngs.py @@ -219,7 +219,7 @@ class MetadataTestCase(unittest.TestCase): discid = "xu338_M8WukSRi0J.KTlDoflB8Y-" # disc 4 metadata = mbngs._getMetadata(response['release'], discid) - self.assertEqual(metadata.releaseType, u'') + self.assertEqual(metadata.releaseType, None) def testAllAvailableMetadata(self): """Check that all possible metadata gets assigned."""