benya/whipper-gui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #98 from ribbons/defeat-cache-config

Browse Source 
Persist False value for defeats_cache correctly
This commit is contained in:
JoeLametta
2017-01-01 19:17:17 +01:00
committed by GitHub
parent 976e1bdca2 3f9cc77e30
commit 17021a68f2
2 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
morituri/common/config.py
View File

@@ -113,7 +113,7 @@ class Config:
section = self._findDriveSection(vendor, model, release)
try:
return bool(self._parser.get(section, 'defeats_cache'))
return self._parser.get(section, 'defeats_cache') == 'True'
except ConfigParser.NoOptionError:
raise KeyError("Could not find defeats_cache for %s/%s/%s" % (
vendor, model, release))

18
morituri/test/test_common_config.py
View File

@@ -9,7 +9,7 @@ from morituri.common import config
from morituri.test import common as tcommon
class OffsetTestCase(tcommon.TestCase):
class ConfigTestCase(tcommon.TestCase):
def setUp(self):
fd, self._path = tempfile.mkstemp(suffix=u'.morituri.test.config')
@@ -50,3 +50,19 @@ class OffsetTestCase(tcommon.TestCase):
offset = self._config.getReadOffset(
'Slimtype', 'eSAU208 2 ', 'ML03')
self.assertEquals(offset, 6)
def testDefeatsCache(self):
self.assertRaises(KeyError, self._config.getDefeatsCache,
'PLEXTOR ', 'DVDR PX-L890SA', '1.05')
self._config.setDefeatsCache(
'PLEXTOR ', 'DVDR PX-L890SA', '1.05', False)
defeats = self._config.getDefeatsCache(
'PLEXTOR ', 'DVDR PX-L890SA', '1.05')
self.assertEquals(defeats, False)
self._config.setDefeatsCache(
'PLEXTOR ', 'DVDR PX-L890SA', '1.05', True)
defeats = self._config.getDefeatsCache(
'PLEXTOR ', 'DVDR PX-L890SA', '1.05')
self.assertEquals(defeats, True)