fix: restore push delivery across clients

fix: stop suppressing server push notifications based on coarse online presence

fix: rely on FCM delivery for message notifications and remove duplicate Android realtime alerts

android/app/src/main/java/ru/daemonlord/messenger/domain/realtime/usecase/HandleRealtimeEventsUseCase.kt

@@ -8,15 +8,12 @@ import kotlinx.coroutines.flow.collectLatest
 import kotlinx.coroutines.launch
 import ru.daemonlord.messenger.data.chat.local.dao.ChatDao
 import ru.daemonlord.messenger.core.notifications.ActiveChatTracker
-import ru.daemonlord.messenger.core.notifications.ChatNotificationPayload
 import ru.daemonlord.messenger.core.notifications.NotificationDispatcher
 import ru.daemonlord.messenger.core.token.TokenRepository
 import ru.daemonlord.messenger.data.message.local.dao.MessageDao
 import ru.daemonlord.messenger.data.message.local.entity.MessageEntity
 import ru.daemonlord.messenger.domain.chat.repository.ChatRepository
 import ru.daemonlord.messenger.domain.message.repository.MessageRepository
-import ru.daemonlord.messenger.domain.notifications.repository.NotificationSettingsRepository
-import ru.daemonlord.messenger.domain.notifications.usecase.ShouldShowMessageNotificationUseCase
 import ru.daemonlord.messenger.domain.realtime.RealtimeManager
 import ru.daemonlord.messenger.domain.realtime.model.RealtimeEvent
 import javax.inject.Inject
@@ -32,8 +29,6 @@ class HandleRealtimeEventsUseCase @Inject constructor(
     private val notificationDispatcher: NotificationDispatcher,
     private val activeChatTracker: ActiveChatTracker,
     private val tokenRepository: TokenRepository,
-    private val notificationSettingsRepository: NotificationSettingsRepository,
-    private val shouldShowMessageNotificationUseCase: ShouldShowMessageNotificationUseCase,
 ) {
 
     private val scope = CoroutineScope(SupervisorJob() + Dispatchers.IO)
@@ -113,37 +108,6 @@ class HandleRealtimeEventsUseCase @Inject constructor(
                             )
                         }
                         chatRepository.refreshChat(chatId = event.chatId)
-                        val muted = chatDao.isChatMuted(event.chatId) == true
-                        val shouldNotify = shouldShowMessageNotificationUseCase(
-                            chatId = event.chatId,
-                            isMention = isMention,
-                            serverMuted = muted,
-                        )
-                        if (!isOwnMessage && activeChatId != event.chatId && shouldNotify) {
-                            val title = chatDao.getChatDisplayTitle(event.chatId) ?: "New message"
-                            val previewEnabled = notificationSettingsRepository.getSettings().previewEnabled
-                            val body = (if (previewEnabled) {
-                                event.text?.takeIf { it.isNotBlank() }
-                            } else {
-                                null
-                            }) ?: when (event.type?.lowercase()) {
-                                    "image" -> "Photo"
-                                    "video" -> "Video"
-                                    "audio" -> "Audio"
-                                    "voice" -> "Voice message"
-                                    "file" -> "File"
-                                    else -> "Open chat"
-                                }
-                            notificationDispatcher.showChatMessage(
-                                ChatNotificationPayload(
-                                    chatId = event.chatId,
-                                    messageId = event.messageId,
-                                    title = title,
-                                    body = body,
-                                    isMention = isMention,
-                                )
-                            )
-                        }
                     }
 
                     is RealtimeEvent.MessageUpdated -> {

app/notifications/service.py

@@ -18,7 +18,6 @@ from app.notifications.schemas import (
     PushTokenUpsertRequest,
 )
 from app.notifications.tasks import send_mention_notification_task, send_push_notification_task
-from app.realtime.presence import is_user_online
 from app.users.repository import list_users_by_ids
 
 _MENTION_RE = re.compile(r"@([A-Za-z0-9_]{3,50})")
@@ -82,24 +81,23 @@ async def dispatch_message_notifications(db: AsyncSession, message: Message) ->
         if await is_chat_muted_for_user(db, chat_id=message.chat_id, user_id=recipient.id):
             continue
 
-        if not await is_user_online(recipient.id):
-            payload = {
-                **base_payload,
-                "type": "offline_message",
-                "text_preview": (message.text or "")[:120],
-            }
-            await create_notification_log(
-                db,
-                user_id=recipient.id,
-                event_type="offline_message",
-                payload=json.dumps(payload, ensure_ascii=True),
-            )
-            send_push_notification_task.delay(
-                recipient.id,
-                f"New message from {sender_name}",
-                (message.text or "")[:120],
-                payload,
-            )
+        payload = {
+            **base_payload,
+            "type": "message",
+            "text_preview": (message.text or "")[:120],
+        }
+        await create_notification_log(
+            db,
+            user_id=recipient.id,
+            event_type="message",
+            payload=json.dumps(payload, ensure_ascii=True),
+        )
+        send_push_notification_task.delay(
+            recipient.id,
+            f"New message from {sender_name}",
+            (message.text or "")[:120],
+            payload,
+        )
 
     await db.commit()