Files
whipper-gui/HACKING
Thomas Vander Stichele 3f4291bb18 Handle off-by-1 errors in cdparanoia progress parsing
Fixes the exception I got on ripping The Strokes - Someday
2013-02-24 11:37:13 +01:00

47 lines
1.6 KiB
Plaintext

style guide
-----------
To avoid confusion:
- cuefile is used for the CueFile object, which wraps/parses an existing .cue
file on disk
- tocfile: same
- toc: table of contents of a CD; instance of Table
test: single rip of kings of leon - only by the night
track 1: frame start 0, 17811 CD frames,
track 2: frame start 17811, 18481 CD frames
ARCue.pl says 2c15499a
track 11: frame start 166858, 25103 CD frames (14760564 audio frames)
191961 total CD frames
unicode
-------
- All text files should be read and written as unicode.
- All strings that came from the outside should be converted to unicode objects.
- Use asserts liberally to ensure this so we catch problems earlier.
- All gst.parse_launch() pipelines should be passed as utf-8; use
encode('utf-8')
- morituri.extern.log.log is not unicode-safe; don't pass it unicode objects;
for example, always use %r to log paths
- run with RIP_DEBUG=5 once in a while to catch unicode/logging errors.
- Also use unicode prefix/suffix in tempfile.* methods; to force unicode.
- filesystems on Unix do not have an encoding. file names are bytes.
However, most distros default to a utf-8 interpretation
- You can either treat paths as byte strings all the way without interpreting
(even when writing them to other files), or assume utf-8 on in and out.
- also direct output to a file; redirection sets codec to ASCII and brings out
unicode bugs
CDROMS
------
PLEXTOR CD-R PX-W8432T Read offset of device is: 355.
Test discs
----------
The Strokes - Someday (promo): has 1 frame silence marked as SILENCE