4 Commits

Author SHA1 Message Date
5baadd9dbb Fix window icon and remove duplicate log 2026-04-18 23:39:20 +03:00
997bfef893 Reduce GUI vertical footprint 2026-04-18 23:33:42 +03:00
290d650f80 Respect system GTK theme 2026-04-18 23:27:22 +03:00
05838116d0 Make GUI more EAC-like 2026-04-18 23:22:04 +03:00
2 changed files with 224 additions and 99 deletions

View File

@@ -36,6 +36,7 @@ from whipper.result import result
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
APP_ID = "com.github.whipper_team.Whipper"
class RipCancelledError(Exception): class RipCancelledError(Exception):
@@ -86,7 +87,9 @@ def _release_duration_distance(metadata, duration_ms):
class WhipperGui(Gtk.Application if Gtk is not None else object): class WhipperGui(Gtk.Application if Gtk is not None else object):
def __init__(self): def __init__(self):
require_gui_runtime() require_gui_runtime()
super().__init__(application_id="com.github.whipper_team.WhipperGui") super().__init__(application_id=APP_ID)
GLib.set_application_name("Whipper")
Gtk.Window.set_default_icon_name(APP_ID)
self.window = None self.window = None
self.main_pane = None self.main_pane = None
@@ -122,6 +125,7 @@ class WhipperGui(Gtk.Application if Gtk is not None else object):
self.logger_combo = None self.logger_combo = None
self.track_template_entry = None self.track_template_entry = None
self.disc_template_entry = None self.disc_template_entry = None
self.compact_mode_label = None
self.release_store = None self.release_store = None
self.release_view = None self.release_view = None
@@ -129,6 +133,7 @@ class WhipperGui(Gtk.Application if Gtk is not None else object):
self.track_view = None self.track_view = None
self.log_buffer = None self.log_buffer = None
self.release_details = None self.release_details = None
self.track_columns = None
self.info_labels = {} self.info_labels = {}
self.status_label = None self.status_label = None
@@ -148,36 +153,47 @@ class WhipperGui(Gtk.Application if Gtk is not None else object):
def _build_window(self): def _build_window(self):
window = Gtk.ApplicationWindow(application=self) window = Gtk.ApplicationWindow(application=self)
window.set_title("Whipper") window.set_title("Whipper")
window.set_icon_name("com.github.whipper_team.Whipper") window.set_icon_name(APP_ID)
window.set_default_size(1120, 760) window.set_default_size(1380, 820)
window.set_border_width(12) window.set_border_width(6)
root = Gtk.Box(orientation=Gtk.Orientation.VERTICAL, spacing=12) root = Gtk.Box(orientation=Gtk.Orientation.VERTICAL, spacing=6)
window.add(root) window.add(root)
root.pack_start(self._build_controls(), False, False, 0) root.pack_start(self._build_transport_strip(), False, False, 0)
root.pack_start(self._build_actions(), False, False, 0)
root.pack_start(self._build_progress(), False, False, 0) root.pack_start(self._build_progress(), False, False, 0)
root.pack_start(self._build_main_content(), True, True, 0) root.pack_start(self._build_main_content(), True, True, 0)
root.pack_start(self._build_log(), True, True, 0)
self._refresh_devices() self._refresh_devices()
self._load_gui_settings() self._load_gui_settings()
window.show_all() window.show_all()
return window return window
def _build_transport_strip(self):
frame = Gtk.Frame(label="Extraction Control Center")
box = Gtk.Box(orientation=Gtk.Orientation.VERTICAL, spacing=6, margin=6)
frame.add(box)
box.pack_start(self._build_controls(), False, False, 0)
box.pack_start(self._build_actions(), False, False, 0)
return frame
def _build_controls(self): def _build_controls(self):
grid = Gtk.Grid(column_spacing=10, row_spacing=10) grid = Gtk.Grid(column_spacing=8, row_spacing=6)
grid.attach(Gtk.Label(label="Drive", xalign=0), 0, 0, 1, 1) grid.attach(Gtk.Label(label="Drive", xalign=0), 0, 0, 1, 1)
self.device_combo = Gtk.ComboBoxText() self.device_combo = Gtk.ComboBoxText()
self.device_combo.connect("changed", self._on_device_changed) self.device_combo.connect("changed", self._on_device_changed)
grid.attach(self.device_combo, 1, 0, 2, 1) grid.attach(self.device_combo, 1, 0, 1, 1)
self.refresh_button = Gtk.Button(label="Refresh Drives") self.refresh_button = Gtk.Button(label="Detect Drives")
self.refresh_button.connect("clicked", self._on_refresh_clicked) self.refresh_button.connect("clicked", self._on_refresh_clicked)
self.refresh_button.set_tooltip_text("Refresh the list of detected optical drives") self.refresh_button.set_tooltip_text("Refresh the list of detected optical drives")
grid.attach(self.refresh_button, 3, 0, 1, 1) grid.attach(self.refresh_button, 2, 0, 1, 1)
grid.attach(Gtk.Label(label="Status", xalign=0), 3, 0, 1, 1)
self.status_label = Gtk.Label(label="Idle", xalign=0)
self.status_label.set_selectable(True)
grid.attach(self.status_label, 4, 0, 2, 1)
grid.attach(Gtk.Label(label="Output", xalign=0), 0, 1, 1, 1) grid.attach(Gtk.Label(label="Output", xalign=0), 0, 1, 1, 1)
self.output_button = Gtk.FileChooserButton( self.output_button = Gtk.FileChooserButton(
@@ -186,55 +202,110 @@ class WhipperGui(Gtk.Application if Gtk is not None else object):
) )
self.output_button.set_filename(os.path.expanduser("~")) self.output_button.set_filename(os.path.expanduser("~"))
self.output_button.connect("file-set", self._on_settings_changed) self.output_button.connect("file-set", self._on_settings_changed)
grid.attach(self.output_button, 1, 1, 3, 1) grid.attach(self.output_button, 1, 1, 2, 1)
grid.attach(Gtk.Label(label="Logger", xalign=0), 3, 1, 1, 1)
self.logger_combo = Gtk.ComboBoxText()
for logger_name in sorted(result.getLoggers()):
self.logger_combo.append(logger_name, logger_name)
self.logger_combo.set_active_id("whipper")
self.logger_combo.connect("changed", self._on_settings_changed)
grid.attach(self.logger_combo, 4, 1, 2, 1)
grid.attach(Gtk.Label(label="Cover Art", xalign=0), 0, 2, 1, 1)
self.cover_art_combo = Gtk.ComboBoxText()
self.cover_art_combo.append("", "Disabled")
self.cover_art_combo.append("file", "Save file")
self.cover_art_combo.append("embed", "Embed only")
self.cover_art_combo.append("complete", "File + embed")
self.cover_art_combo.set_active(0)
self.cover_art_combo.connect("changed", self._on_settings_changed)
grid.attach(self.cover_art_combo, 1, 2, 1, 1)
grid.attach(Gtk.Label(label="Offset", xalign=0), 2, 2, 1, 1)
self.offset_spin = Gtk.SpinButton.new_with_range(-5000, 5000, 1)
self.offset_spin.set_value(0)
self.offset_spin.connect("value-changed", self._on_settings_changed)
grid.attach(self.offset_spin, 3, 2, 1, 1)
grid.attach(Gtk.Label(label="Retries", xalign=0), 4, 2, 1, 1)
self.max_retries_spin = Gtk.SpinButton.new_with_range(0, 20, 1)
self.max_retries_spin.set_value(5)
self.max_retries_spin.connect("value-changed", self._on_settings_changed)
grid.attach(self.max_retries_spin, 5, 2, 1, 1)
grid.attach(Gtk.Label(label="Working Dir", xalign=0), 0, 2, 1, 1) grid.attach(Gtk.Label(label="Working Dir", xalign=0), 0, 2, 1, 1)
self.working_directory_entry = Gtk.Entry() self.working_directory_entry = Gtk.Entry()
self.working_directory_entry.set_placeholder_text("Optional working directory") self.working_directory_entry.set_placeholder_text("Optional working directory")
self.working_directory_entry.connect("changed", self._on_settings_changed) self.working_directory_entry.connect("changed", self._on_settings_changed)
grid.attach(self.working_directory_entry, 1, 2, 3, 1) grid.attach(self.working_directory_entry, 1, 3, 2, 1)
grid.attach(Gtk.Label(label="Country", xalign=0), 0, 3, 1, 1) grid.attach(Gtk.Label(label="Country", xalign=0), 0, 4, 1, 1)
self.country_entry = Gtk.Entry() self.country_entry = Gtk.Entry()
self.country_entry.set_placeholder_text("Optional MusicBrainz country filter") self.country_entry.set_placeholder_text("Optional MusicBrainz country filter")
self.country_entry.connect("changed", self._on_settings_changed) self.country_entry.connect("changed", self._on_settings_changed)
grid.attach(self.country_entry, 1, 3, 1, 1) grid.attach(self.country_entry, 1, 4, 1, 1)
grid.attach(Gtk.Label(label="Release ID", xalign=0), 2, 3, 1, 1) grid.attach(Gtk.Label(label="Release ID", xalign=0), 2, 4, 1, 1)
self.release_id_entry = Gtk.Entry() self.release_id_entry = Gtk.Entry()
self.release_id_entry.set_placeholder_text("Optional release override") self.release_id_entry.set_placeholder_text("Optional release override")
self.release_id_entry.connect("changed", self._on_settings_changed) self.release_id_entry.connect("changed", self._on_settings_changed)
grid.attach(self.release_id_entry, 3, 3, 1, 1) grid.attach(self.release_id_entry, 3, 4, 3, 1)
return grid return grid
def _build_actions(self): def _build_actions(self):
box = Gtk.Box(orientation=Gtk.Orientation.HORIZONTAL, spacing=10) box = Gtk.Box(orientation=Gtk.Orientation.HORIZONTAL, spacing=8)
self.read_button = Gtk.Button(label="Read Disc") self.read_button = Gtk.Button(label="Detect TOC")
self.read_button.connect("clicked", self._on_read_clicked) self.read_button.connect("clicked", self._on_read_clicked)
self.read_button.set_tooltip_text("Read TOC and fetch matching MusicBrainz releases") self.read_button.set_tooltip_text("Read TOC and fetch matching MusicBrainz releases")
box.pack_start(self.read_button, False, False, 0) box.pack_start(self.read_button, False, False, 0)
self.rip_button = Gtk.Button(label="Rip Selected Release") self.rip_button = Gtk.Button(label="Secure Rip")
self.rip_button.connect("clicked", self._on_rip_clicked) self.rip_button.connect("clicked", self._on_rip_clicked)
self.rip_button.set_tooltip_text("Rip the current disc using the selected release metadata") self.rip_button.set_tooltip_text("Rip the current disc using the selected release metadata")
self.rip_button.set_sensitive(False) self.rip_button.set_sensitive(False)
box.pack_start(self.rip_button, False, False, 0) box.pack_start(self.rip_button, False, False, 0)
self.stop_button = Gtk.Button(label="Stop") self.stop_button = Gtk.Button(label="Abort")
self.stop_button.connect("clicked", self._on_stop_clicked) self.stop_button.connect("clicked", self._on_stop_clicked)
self.stop_button.set_tooltip_text("Cancel the current scan or rip") self.stop_button.set_tooltip_text("Cancel the current scan or rip")
self.stop_button.set_sensitive(False) self.stop_button.set_sensitive(False)
box.pack_start(self.stop_button, False, False, 0) box.pack_start(self.stop_button, False, False, 0)
self.status_label = Gtk.Label(label="Idle", xalign=0) box.pack_start(Gtk.Separator(orientation=Gtk.Orientation.VERTICAL), False, False, 6)
box.pack_start(self.status_label, True, True, 0)
self.unknown_check = Gtk.CheckButton(label="Unknown")
self.unknown_check.set_active(True)
self.unknown_check.connect("toggled", self._on_unknown_toggled)
box.pack_start(self.unknown_check, False, False, 0)
self.cdr_check = Gtk.CheckButton(label="CD-R")
self.cdr_check.connect("toggled", self._on_settings_changed)
box.pack_start(self.cdr_check, False, False, 0)
self.keep_going_check = Gtk.CheckButton(label="Keep Going")
self.keep_going_check.set_active(True)
self.keep_going_check.connect("toggled", self._on_settings_changed)
box.pack_start(self.keep_going_check, False, False, 0)
self.overread_check = Gtk.CheckButton(label="Overread")
self.overread_check.connect("toggled", self._on_settings_changed)
box.pack_start(self.overread_check, False, False, 0)
box.pack_start(Gtk.Separator(orientation=Gtk.Orientation.VERTICAL), False, False, 6)
self.compact_mode_label = Gtk.Label(
label="Compact EAC-style flow: Detect TOC -> pick release -> Secure Rip",
xalign=0,
)
box.pack_start(self.compact_mode_label, True, True, 0)
return box return box
def _build_progress(self): def _build_progress(self):
frame = Gtk.Frame(label="Progress") frame = Gtk.Frame(label="Extraction Progress")
box = Gtk.Box(orientation=Gtk.Orientation.VERTICAL, spacing=8, margin=10) box = Gtk.Box(orientation=Gtk.Orientation.VERTICAL, spacing=4, margin=6)
frame.add(box) frame.add(box)
self.progress_label = Gtk.Label(label="No task running", xalign=0) self.progress_label = Gtk.Label(label="No task running", xalign=0)
@@ -251,18 +322,27 @@ class WhipperGui(Gtk.Application if Gtk is not None else object):
return frame return frame
def _build_main_content(self): def _build_main_content(self):
pane = Gtk.Paned.new(Gtk.Orientation.HORIZONTAL) pane = Gtk.Paned.new(Gtk.Orientation.VERTICAL)
pane.set_wide_handle(True) pane.set_wide_handle(True)
pane.pack1(self._build_left_panel(), resize=True, shrink=False) pane.pack1(self._build_workspace(), resize=True, shrink=False)
pane.pack2(self._build_right_panel(), resize=True, shrink=False) pane.pack2(self._build_log(), resize=False, shrink=False)
pane.set_position(560)
self.main_pane = pane self.main_pane = pane
return pane return pane
def _build_workspace(self):
pane = Gtk.Paned.new(Gtk.Orientation.HORIZONTAL)
pane.set_wide_handle(True)
pane.pack1(self._build_left_panel(), resize=False, shrink=False)
pane.pack2(self._build_right_panel(), resize=True, shrink=False)
pane.set_position(360)
return pane
def _build_left_panel(self): def _build_left_panel(self):
box = Gtk.Box(orientation=Gtk.Orientation.VERTICAL, spacing=12) box = Gtk.Box(orientation=Gtk.Orientation.VERTICAL, spacing=8)
info_frame = Gtk.Frame(label="Disc") info_frame = Gtk.Frame(label="Disc")
info_grid = Gtk.Grid(column_spacing=10, row_spacing=6, margin=10) info_grid = Gtk.Grid(column_spacing=8, row_spacing=4, margin=6)
info_frame.add(info_grid) info_frame.add(info_grid)
rows = [ rows = [
@@ -281,17 +361,23 @@ class WhipperGui(Gtk.Application if Gtk is not None else object):
box.pack_start(info_frame, False, False, 0) box.pack_start(info_frame, False, False, 0)
release_frame = Gtk.Frame(label="Matching Releases") release_frame = Gtk.Frame(label="Metadata / Releases")
release_box = Gtk.Box(orientation=Gtk.Orientation.VERTICAL, spacing=8, margin=8) release_box = Gtk.Box(orientation=Gtk.Orientation.VERTICAL, spacing=6, margin=6)
release_frame.add(release_box) release_frame.add(release_box)
self.release_store = Gtk.ListStore(str, str, str, str, str, object) self.release_store = Gtk.ListStore(str, str, str, str, str, object)
self.release_view = Gtk.TreeView(model=self.release_store) self.release_view = Gtk.TreeView(model=self.release_store)
self.release_view.set_headers_clickable(False)
self.release_view.set_enable_search(False)
self.release_view.set_fixed_height_mode(True)
self.release_view.set_grid_lines(Gtk.TreeViewGridLines.BOTH)
self.release_view.get_selection().connect("changed", self._on_release_selected) self.release_view.get_selection().connect("changed", self._on_release_selected)
for index, title in enumerate(["Artist", "Title", "Year", "Type", "Country"]): for index, title in enumerate(["Artist", "Title", "Year", "Type", "Country"]):
renderer = Gtk.CellRendererText() renderer = Gtk.CellRendererText()
column = Gtk.TreeViewColumn(title, renderer, text=index) column = Gtk.TreeViewColumn(title, renderer, text=index)
column.set_resizable(True) column.set_resizable(True)
if title in {"Artist", "Title"}:
column.set_expand(True)
self.release_view.append_column(column) self.release_view.append_column(column)
scroll = Gtk.ScrolledWindow() scroll = Gtk.ScrolledWindow()
@@ -304,7 +390,7 @@ class WhipperGui(Gtk.Application if Gtk is not None else object):
details_scroll = Gtk.ScrolledWindow() details_scroll = Gtk.ScrolledWindow()
details_scroll.set_hexpand(True) details_scroll.set_hexpand(True)
details_scroll.set_vexpand(False) details_scroll.set_vexpand(False)
details_scroll.set_min_content_height(120) details_scroll.set_min_content_height(90)
details_frame.add(details_scroll) details_frame.add(details_scroll)
self.release_details = Gtk.Label(label="Select a release to inspect it.", xalign=0, yalign=0) self.release_details = Gtk.Label(label="Select a release to inspect it.", xalign=0, yalign=0)
@@ -314,21 +400,40 @@ class WhipperGui(Gtk.Application if Gtk is not None else object):
release_box.pack_start(details_frame, False, False, 0) release_box.pack_start(details_frame, False, False, 0)
box.pack_start(release_frame, True, True, 0) box.pack_start(release_frame, True, True, 0)
box.set_size_request(420, -1)
return box return box
def _build_right_panel(self): def _build_right_panel(self):
box = Gtk.Box(orientation=Gtk.Orientation.VERTICAL, spacing=12) box = Gtk.Box(orientation=Gtk.Orientation.VERTICAL, spacing=6)
tracks_frame = Gtk.Frame(label="Tracks") tracks_frame = Gtk.Frame(label="Track Extraction Matrix")
tracks_box = Gtk.Box(orientation=Gtk.Orientation.VERTICAL, spacing=8, margin=8) tracks_box = Gtk.Box(orientation=Gtk.Orientation.VERTICAL, spacing=6, margin=6)
tracks_frame.add(tracks_box) tracks_frame.add(tracks_box)
self.track_store = Gtk.ListStore(str, str, str, str) self.track_columns = {
"number": 0,
"status": 1,
"artist": 2,
"title": 3,
"length": 4,
"test_crc": 5,
"copy_crc": 6,
"accuraterip": 7,
}
self.track_store = Gtk.ListStore(str, str, str, str, str, str, str, str)
self.track_view = Gtk.TreeView(model=self.track_store) self.track_view = Gtk.TreeView(model=self.track_store)
for index, title in enumerate(["#", "Artist", "Title", "Length"]): self.track_view.set_headers_clickable(False)
self.track_view.set_enable_search(False)
self.track_view.set_fixed_height_mode(True)
self.track_view.set_grid_lines(Gtk.TreeViewGridLines.BOTH)
for index, title in enumerate(["#", "Status", "Artist", "Title", "Length", "Test CRC", "Copy CRC", "AR"]):
renderer = Gtk.CellRendererText() renderer = Gtk.CellRendererText()
column = Gtk.TreeViewColumn(title, renderer, text=index) column = Gtk.TreeViewColumn(title, renderer, text=index)
column.set_resizable(True) column.set_resizable(True)
if title in {"Artist", "Title"}:
column.set_expand(True)
if title == "Status":
column.set_min_width(140)
self.track_view.append_column(column) self.track_view.append_column(column)
track_scroll = Gtk.ScrolledWindow() track_scroll = Gtk.ScrolledWindow()
@@ -337,89 +442,42 @@ class WhipperGui(Gtk.Application if Gtk is not None else object):
track_scroll.add(self.track_view) track_scroll.add(self.track_view)
tracks_box.pack_start(track_scroll, True, True, 0) tracks_box.pack_start(track_scroll, True, True, 0)
tracks_box.pack_start(self._build_rip_options(), False, False, 0)
box.pack_start(tracks_frame, True, True, 0) box.pack_start(tracks_frame, True, True, 0)
box.pack_start(self._build_rip_options(), False, False, 0)
return box return box
def _build_rip_options(self): def _build_rip_options(self):
frame = Gtk.Frame(label="Rip Options") frame = Gtk.Frame(label="Extraction Setup")
grid = Gtk.Grid(column_spacing=10, row_spacing=8, margin=10) grid = Gtk.Grid(column_spacing=8, row_spacing=4, margin=6)
frame.add(grid) frame.add(grid)
self.unknown_check = Gtk.CheckButton(label="Allow ripping without metadata") grid.attach(Gtk.Label(label="Track Tpl", xalign=0), 0, 0, 1, 1)
self.unknown_check.set_active(True)
self.unknown_check.connect("toggled", self._on_unknown_toggled)
grid.attach(self.unknown_check, 0, 0, 2, 1)
self.cdr_check = Gtk.CheckButton(label="Allow CD-R")
self.cdr_check.connect("toggled", self._on_settings_changed)
grid.attach(self.cdr_check, 2, 0, 1, 1)
self.keep_going_check = Gtk.CheckButton(label="Keep going on failed tracks")
self.keep_going_check.set_active(True)
self.keep_going_check.connect("toggled", self._on_settings_changed)
grid.attach(self.keep_going_check, 0, 1, 2, 1)
self.overread_check = Gtk.CheckButton(label="Force overread")
self.overread_check.connect("toggled", self._on_settings_changed)
grid.attach(self.overread_check, 2, 1, 1, 1)
grid.attach(Gtk.Label(label="Cover Art", xalign=0), 0, 2, 1, 1)
self.cover_art_combo = Gtk.ComboBoxText()
self.cover_art_combo.append("", "Disabled")
self.cover_art_combo.append("file", "Save file")
self.cover_art_combo.append("embed", "Embed only")
self.cover_art_combo.append("complete", "File + embed")
self.cover_art_combo.set_active(0)
self.cover_art_combo.connect("changed", self._on_settings_changed)
grid.attach(self.cover_art_combo, 1, 2, 1, 1)
grid.attach(Gtk.Label(label="Max Retries", xalign=0), 2, 2, 1, 1)
self.max_retries_spin = Gtk.SpinButton.new_with_range(0, 20, 1)
self.max_retries_spin.set_value(5)
self.max_retries_spin.connect("value-changed", self._on_settings_changed)
grid.attach(self.max_retries_spin, 3, 2, 1, 1)
grid.attach(Gtk.Label(label="Offset", xalign=0), 0, 3, 1, 1)
self.offset_spin = Gtk.SpinButton.new_with_range(-5000, 5000, 1)
self.offset_spin.set_value(0)
self.offset_spin.connect("value-changed", self._on_settings_changed)
grid.attach(self.offset_spin, 1, 3, 1, 1)
grid.attach(Gtk.Label(label="Logger", xalign=0), 2, 3, 1, 1)
self.logger_combo = Gtk.ComboBoxText()
for logger_name in sorted(result.getLoggers()):
self.logger_combo.append(logger_name, logger_name)
self.logger_combo.set_active_id("whipper")
self.logger_combo.connect("changed", self._on_settings_changed)
grid.attach(self.logger_combo, 3, 3, 1, 1)
grid.attach(Gtk.Label(label="Track Tpl", xalign=0), 0, 4, 1, 1)
self.track_template_entry = Gtk.Entry() self.track_template_entry = Gtk.Entry()
self.track_template_entry.set_text(cd_command.DEFAULT_TRACK_TEMPLATE) self.track_template_entry.set_text(cd_command.DEFAULT_TRACK_TEMPLATE)
self.track_template_entry.connect("changed", self._on_settings_changed) self.track_template_entry.connect("changed", self._on_settings_changed)
grid.attach(self.track_template_entry, 1, 4, 3, 1) grid.attach(self.track_template_entry, 1, 0, 3, 1)
grid.attach(Gtk.Label(label="Disc Tpl", xalign=0), 0, 5, 1, 1) grid.attach(Gtk.Label(label="Disc Tpl", xalign=0), 0, 1, 1, 1)
self.disc_template_entry = Gtk.Entry() self.disc_template_entry = Gtk.Entry()
self.disc_template_entry.set_text(cd_command.DEFAULT_DISC_TEMPLATE) self.disc_template_entry.set_text(cd_command.DEFAULT_DISC_TEMPLATE)
self.disc_template_entry.connect("changed", self._on_settings_changed) self.disc_template_entry.connect("changed", self._on_settings_changed)
grid.attach(self.disc_template_entry, 1, 5, 3, 1) grid.attach(self.disc_template_entry, 1, 1, 3, 1)
note = Gtk.Label( note = Gtk.Label(
label="The configured drive offset is loaded automatically when whipper knows this drive.", label="Advanced templates stay here; fast extraction switches moved to the control center to reduce vertical space.",
xalign=0, xalign=0,
) )
note.set_line_wrap(True) note.set_line_wrap(True)
grid.attach(note, 0, 6, 4, 1) grid.attach(note, 0, 2, 4, 1)
return frame return frame
def _build_log(self): def _build_log(self):
frame = Gtk.Frame(label="Log") frame = Gtk.Frame(label="Extraction Log")
scroll = Gtk.ScrolledWindow() scroll = Gtk.ScrolledWindow()
scroll.set_hexpand(True) scroll.set_hexpand(True)
scroll.set_vexpand(True) scroll.set_vexpand(False)
scroll.set_min_content_height(150)
frame.add(scroll) frame.add(scroll)
text_view = Gtk.TextView() text_view = Gtk.TextView()
@@ -621,11 +679,24 @@ class WhipperGui(Gtk.Application if Gtk is not None else object):
for index, track in enumerate(metadata.tracks, start=1): for index, track in enumerate(metadata.tracks, start=1):
self.track_store.append([ self.track_store.append([
str(index), str(index),
"Ready",
track.artist or "", track.artist or "",
track.title or "", track.title or "",
_format_duration_ms(track.duration), _format_duration_ms(track.duration),
"",
"",
"",
]) ])
def _set_track_field(self, track_number, field, value):
if track_number <= 0 or self.track_store is None or self.track_columns is None:
return False
row_index = track_number - 1
if row_index < 0 or row_index >= len(self.track_store):
return False
self.track_store[row_index][self.track_columns[field]] = value
return False
def _update_release_details(self, metadata): def _update_release_details(self, metadata):
if metadata is None: if metadata is None:
self.release_details.set_text("Select a release to inspect it.") self.release_details.set_text("Select a release to inspect it.")
@@ -836,6 +907,14 @@ class WhipperGui(Gtk.Application if Gtk is not None else object):
self.track_bar.set_fraction(value) self.track_bar.set_fraction(value)
self.track_bar.set_text(description) self.track_bar.set_text(description)
self.progress_label.set_text("%s: %s" % (item_label, description)) self.progress_label.set_text("%s: %s" % (item_label, description))
if item_label.startswith("Track "):
try:
track_number = int(item_label.split()[1])
except (IndexError, ValueError):
track_number = None
if track_number is not None:
percent = int(value * 100)
self._set_track_field(track_number, "status", "%s %d%%" % (description, percent))
return False return False
def _mark_track_finished(self, item_label, item_index, item_total, skipped=False): def _mark_track_finished(self, item_label, item_index, item_total, skipped=False):
@@ -846,6 +925,13 @@ class WhipperGui(Gtk.Application if Gtk is not None else object):
self.track_bar.set_fraction(1.0) self.track_bar.set_fraction(1.0)
self.track_bar.set_text("%s %s" % (item_label, "skipped" if skipped else "done")) self.track_bar.set_text("%s %s" % (item_label, "skipped" if skipped else "done"))
self.progress_label.set_text("%s %s" % (item_label, "failed" if skipped else "verified")) self.progress_label.set_text("%s %s" % (item_label, "failed" if skipped else "verified"))
if item_label.startswith("Track "):
try:
track_number = int(item_label.split()[1])
except (IndexError, ValueError):
track_number = None
if track_number is not None:
self._set_track_field(track_number, "status", "Skipped" if skipped else "Verified")
return False return False
def _finish_rip(self, returncode, status="Done"): def _finish_rip(self, returncode, status="Done"):
@@ -891,6 +977,8 @@ class WhipperGui(Gtk.Application if Gtk is not None else object):
if os.path.exists(path): if os.path.exists(path):
GLib.idle_add(self._append_log, "%s already exists, verifying\n" % item_label) GLib.idle_add(self._append_log, "%s already exists, verifying\n" % item_label)
if track_number > 0:
GLib.idle_add(self._set_track_field, track_number, "status", "Verifying existing")
if not program.verifyTrack(runner, track_result): if not program.verifyTrack(runner, track_result):
GLib.idle_add(self._append_log, "%s verification failed, reripping\n" % item_label) GLib.idle_add(self._append_log, "%s verification failed, reripping\n" % item_label)
os.unlink(path) os.unlink(path)
@@ -904,6 +992,13 @@ class WhipperGui(Gtk.Application if Gtk is not None else object):
raise RipCancelledError("Rip cancelled") raise RipCancelledError("Rip cancelled")
extra = "" if tries == 1 else " (try %d)" % tries extra = "" if tries == 1 else " (try %d)" % tries
GLib.idle_add(self._append_log, "%s%s: %s\n" % (item_label, extra, os.path.basename(path))) GLib.idle_add(self._append_log, "%s%s: %s\n" % (item_label, extra, os.path.basename(path)))
if track_number > 0:
GLib.idle_add(
self._set_track_field,
track_number,
"status",
"Test & Copy%s" % extra,
)
tag_list = program.getTagList(track_number, mbdiscid) tag_list = program.getTagList(track_number, mbdiscid)
if track_number > 0 and itable.tracks[track_number - 1].isrc is not None: if track_number > 0 and itable.tracks[track_number - 1].isrc is not None:
@@ -940,6 +1035,19 @@ class WhipperGui(Gtk.Application if Gtk is not None else object):
track_result.copyduration += rip_task.copyduration track_result.copyduration += rip_task.copyduration
if track_result.filename != rip_task.path: if track_result.filename != rip_task.path:
track_result.filename = rip_task.path track_result.filename = rip_task.path
if track_number > 0:
GLib.idle_add(
self._set_track_field,
track_number,
"test_crc",
"%08X" % track_result.testcrc if track_result.testcrc is not None else "",
)
GLib.idle_add(
self._set_track_field,
track_number,
"copy_crc",
"%08X" % track_result.copycrc if track_result.copycrc is not None else "",
)
break break
except Exception as exc: except Exception as exc:
if self.rip_cancel_requested: if self.rip_cancel_requested:
@@ -953,6 +1061,8 @@ class WhipperGui(Gtk.Application if Gtk is not None else object):
if settings["keep_going"]: if settings["keep_going"]:
track_result.skipped = True track_result.skipped = True
skipped_tracks.append(track_result) skipped_tracks.append(track_result)
if track_number > 0:
GLib.idle_add(self._set_track_field, track_number, "accuraterip", "Skipped")
GLib.idle_add(self._mark_track_finished, item_label, item_index, item_total, True) GLib.idle_add(self._mark_track_finished, item_label, item_index, item_total, True)
return return
raise RuntimeError("%s can't be ripped" % item_label) raise RuntimeError("%s can't be ripped" % item_label)
@@ -962,6 +1072,8 @@ class WhipperGui(Gtk.Application if Gtk is not None else object):
return return
if track_result.testcrc != track_result.copycrc: if track_result.testcrc != track_result.copycrc:
if track_number > 0:
GLib.idle_add(self._set_track_field, track_number, "accuraterip", "CRC mismatch")
raise RuntimeError("CRCs did not match for %s" % item_label) raise RuntimeError("CRCs did not match for %s" % item_label)
if track_number == 0: if track_number == 0:
@@ -985,6 +1097,7 @@ class WhipperGui(Gtk.Application if Gtk is not None else object):
program.result.table.getTrackLength(track_number), program.result.table.getTrackLength(track_number),
track_number, track_number,
) )
GLib.idle_add(self._set_track_field, track_number, "accuraterip", "Pending AR")
GLib.idle_add(self._mark_track_finished, item_label, item_index, item_total, False) GLib.idle_add(self._mark_track_finished, item_label, item_index, item_total, False)

View File

@@ -277,6 +277,16 @@ def _make_ui_app(tmp_path):
app.track_bar = FakeProgressBar() app.track_bar = FakeProgressBar()
app.release_store = FakeListStore() app.release_store = FakeListStore()
app.track_store = FakeListStore() app.track_store = FakeListStore()
app.track_columns = {
"number": 0,
"status": 1,
"artist": 2,
"title": 3,
"length": 4,
"test_crc": 5,
"copy_crc": 6,
"accuraterip": 7,
}
app.release_view = FakeReleaseView(app.release_store) app.release_view = FakeReleaseView(app.release_store)
app.release_details = FakeLabel() app.release_details = FakeLabel()
app.info_labels = {key: FakeLabel() for key in [ app.info_labels = {key: FakeLabel() for key in [
@@ -305,6 +315,7 @@ def _make_ui_app(tmp_path):
"_set_running_state", "_set_running_state",
"_update_release_store", "_update_release_store",
"_update_track_store", "_update_track_store",
"_set_track_field",
"_update_release_details", "_update_release_details",
"_update_rip_task_progress", "_update_rip_task_progress",
"_finish_rip", "_finish_rip",
@@ -390,7 +401,8 @@ def test_release_selection_and_progress_updates(monkeypatch, tmp_path):
gui.WhipperGui._finish_rip(app, 0, "Done") gui.WhipperGui._finish_rip(app, 0, "Done")
assert app.current_release is metadata assert app.current_release is metadata
assert app.track_store[0][1] == "Track Artist" assert app.track_store[0][2] == "Track Artist"
assert app.track_store[0][1].startswith("Encoding")
assert app.release_details.get_text().startswith("Artist: Artist") assert app.release_details.get_text().startswith("Artist: Artist")
assert app.overall_bar.fraction == 1.0 assert app.overall_bar.fraction == 1.0
assert app.track_bar.fraction == 1.0 assert app.track_bar.fraction == 1.0