Commit Graph

170 Commits

Author SHA1 Message Date
Thomas Vander Stichele
c301015537 * morituri/common/checksum.py:
* morituri/common/encode.py:
	* morituri/image/table.py:
	* morituri/rip/cd.py:
	* morituri/rip/image.py:
	* morituri/rip/offset.py:
	* morituri/test/test_common_accurip.py:
	* morituri/test/test_common_checksum.py:
	* morituri/test/test_image_cue.py:
	* morituri/test/test_image_table.py:
	  Pychecker fixes.
2011-05-21 11:50:39 +00:00
Thomas Vander Stichele
0da5dd0aa1 * morituri/common/checksum.py:
Actually raise the exception.
	* morituri/common/task.py:
	  Document interface more clearly.
	* morituri/test/test_common_checksum.py:
	  Use tcommon for test.common
2011-05-21 11:22:04 +00:00
Thomas Vander Stichele
019ad538d8 * morituri/common/common.py:
Don't fail on loading pickle.
2011-05-19 10:03:30 +00:00
Thomas Vander Stichele
0b520f2e86 * morituri/common/encode.py:
Alac does not have merge_tags.  Fixes #15.
2011-05-19 01:23:53 +00:00
Thomas Vander Stichele
f70ba7cb32 * morituri/program/cdparanoia.py:
* morituri/common/encode.py:
	* morituri/common/program.py:
	* morituri/rip/cd.py:
	  Add action and what args to describe task better.
2011-05-19 00:28:36 +00:00
Thomas Vander Stichele
9fe80e238e * morituri/common/task.py:
Add more debug.
2011-05-19 00:27:20 +00:00
Thomas Vander Stichele
7bd0c5e2c0 * morituri/common/encode.py:
wavenc does not have merge_tags, it seems.
	  So don't call an element a tagger, don't merge tags if there is
	  no tagger, and complain if there is no merge_tags when we think
	  there should be.
2011-04-08 09:04:25 +00:00
Thomas Vander Stichele
6a8355b109 * morituri/common/program.py:
* morituri/rip/offset.py:
	  When finding the offset, also load and possibly unmount, resolving
	  to the real path for the device.
2011-03-22 17:31:36 +00:00
Thomas Vander Stichele
335b49e4b4 * morituri/common/encode.py:
Debug failing to write tags better.  See #60.
2011-03-20 18:39:28 +00:00
Thomas Vander Stichele
e52d20c19a * morituri/common/checksum.py:
Create a GstException to wrap a Gst.GError.
	  Create a base GstPipelineTask class.
	  Use it in Checksum and TRM tasks.
	  Raise and don't proceed to call .paused() when a GstError happens.
	  Should help debug https://bugs.launchpad.net/bugs/735053
	* morituri/test/test_common_checksum.py:
	  Adapt test.
2011-03-15 22:44:05 +00:00
Thomas Vander Stichele
d0c87c3861 add doc 2011-03-15 22:41:08 +00:00
Thomas Vander Stichele
a05410051c patch by: Ross Burton
* morituri/common/program.py:
	  On compilation albums the album artist is different to the artist.
	  If this is the case, morituri should write both tags.
	  Fixes #43.
2011-01-09 21:34:21 +00:00
Thomas Vander Stichele
1216f13598 patch by: Ross Burton
* morituri/common/program.py:
	  On compilation albums the album artist is different to the artist.
	  If this is the case, morituri should write both tags.
	  Fixes #43.
2011-01-09 21:15:44 +00:00
Thomas Vander Stichele
08fc4f67a6 * morituri/common/program.py:
* morituri/image/table.py:
	* morituri/rip/cd.py:
	  Get CDDB disc id.  Use it to print info when not found on
	  MusicBrainz.
2011-01-02 17:14:26 +00:00
Thomas Vander Stichele
6581261a76 * morituri/common/program.py:
* morituri/rip/cd.py:
	  Add load and eject device.  Do so before and after ripping.
2011-01-01 11:24:26 +00:00
Thomas Vander Stichele
e104981a54 add track 2010-11-08 19:30:45 +00:00
Thomas Vander Stichele
eebd632eef * morituri/common/program.py:
Comment where we got the template variables from.
	* morituri/rip/cd.py:
	  Document the template variables.
2010-07-08 21:37:49 +00:00
Thomas Vander Stichele
0c5e13ce0f * morituri/common/common.py:
Add MissingDependencyException.
	* morituri/program/cdrdao.py:
	* morituri/rip/main.py:
	  Use it to warn about missing cdrdao.
2010-06-18 22:02:53 +00:00
Thomas Vander Stichele
babf47ec1d * morituri/common/task.py:
Add exception traceback for easier debugging.
2010-06-18 21:52:20 +00:00
Thomas Vander Stichele
757abde725 display checksum as hex instead so it is the same as the other one 2010-05-23 18:33:00 +00:00
Thomas Vander Stichele
b918630f5e * morituri/common/program.py:
Set results by default so that it is set even if we get an
	  exception getting them.
	  Fixes #35.
2010-05-23 18:29:08 +00:00
Thomas Vander Stichele
a4a1df9d2f remove print 2010-04-16 21:12:11 +00:00
Thomas Vander Stichele
5a778deca7 move checksum import inline so we don't import gst again 2010-04-16 21:11:50 +00:00
Thomas Vander Stichele
57b7057bd3 don't fail on htoa because we have no musicbrainz info 2010-04-16 20:59:15 +00:00
Thomas Vander Stichele
c68848026a * morituri/common/encode.py:
* morituri/rip/image.py:
	  Provide status on the retagging.
2010-04-14 22:01:45 +00:00
Thomas Vander Stichele
3361edbee2 * morituri/common/encode.py:
Before moving the newly tagged file to overwrite the original
	  one, copy over mode.
2010-04-14 21:44:09 +00:00
Thomas Vander Stichele
db58d6da05 * morituri/common/program.py:
Commit one missing line from patch in #4 for multi-artist discs.
2010-04-14 08:03:10 +00:00
Thomas Vander Stichele
ed6c468fba * morituri/common/program.py:
Commit one missing line from patch in #4 for multi-artist discs.
2010-04-14 08:02:35 +00:00
Thomas Vander Stichele
db74af7ff4 patch by: Peter Oliver.
* morituri/common/program.py:
	  Handle multi-artist releases where track artist is unset.
	  Fixes #14.
2010-04-14 07:58:14 +00:00
Thomas Vander Stichele
cee915fbd2 * morituri/common/encode.py:
Fix wrong code for checksum comparison.
2010-04-13 22:10:06 +00:00
Thomas Vander Stichele
25ed7459b1 * morituri/common/program.py:
Rename some vars to start with mbid.  Fix pychecker issues.
2010-04-13 22:09:22 +00:00
Thomas Vander Stichele
4cc8b753b8 pychecker fix 2010-04-13 21:58:13 +00:00
Thomas Vander Stichele
297451ea0e * morituri/common/program.py:
Add a retagging command.
	  Add a getMusicBrainz() method.
	* morituri/rip/cd.py:
	  Use it.
	* morituri/image/image.py:
	  Add a task to retag an image.
	* morituri/rip/image.py:
	  Add a command to retag an image.
2010-04-13 21:57:29 +00:00
Thomas Vander Stichele
d9ca12d7cc * morituri/common/encode.py:
Add tasks to read, write, and safely retag flac files.
	* morituri/test/test_common_encode.py:
	  Add tests for this.
2010-04-13 21:55:35 +00:00
Thomas Vander Stichele
7515cf9e73 * morituri/common/checksum.py:
Style fixes.
	* morituri/common/common.py:
	  Add functions to convert a gst.TagList to a dict and compare them.
	* morituri/common/task.py:
	  Add setAndRaiseException which gives us an appropriate
	  exceptionMessage as if we raised where we called this new function.
2010-04-13 21:53:43 +00:00
Thomas Vander Stichele
310a3789c0 * morituri/common/encode.py:
pychecker fix.
2010-04-13 14:12:17 +00:00
Thomas Vander Stichele
a787676239 * morituri/common/encode.py:
Add a task to read tags.
	* morituri/test/test_common_encode.py:
	  Add a test.
2010-04-13 07:37:01 +00:00
Thomas Vander Stichele
2e7a3974c4 * morituri/common/encode.py:
Add a vbr profile.
2010-04-11 17:14:37 +00:00
Thomas Vander Stichele
e124c79c64 * morituri/program/cdparanoia.py:
Add some debug.
	* morituri/common/encode.py:
	  Add more debug.
	  Handle the case where peak is full scale, and peakdB thus 0,
	  which triggered not setting self.peak.
2010-04-08 21:06:52 +00:00
Thomas Vander Stichele
1a5a32f7d1 pychecker fix 2010-04-06 00:19:12 +00:00
Thomas Vander Stichele
39d3265a4a remove whitespace 2010-04-06 00:19:06 +00:00
Thomas Vander Stichele
af0909600d patch by: Peter Oliver.
* morituri/common/program.py:
	  Allow using sortName for artist/track using %S/%s.
	  Fixes #19.
2010-04-06 00:17:40 +00:00
Thomas Vander Stichele
98213c4196 * doc/release:
Document having clean test run.
	* morituri/common/encode.py:
	  Catch and properly stop on gst.QueryError.
	  Don't set peak in stop if we had an error.
	* morituri/test/test_common_encode.py:
	* morituri/test/test_common_renamer.py:
	* morituri/test/test_image_cue.py:
	  Clean up after tests.
2010-04-06 00:02:56 +00:00
Thomas Vander Stichele
f978907fcf * morituri/common/task.py:
* morituri/image/cue.py:
	  Add logCategory.
	* morituri/image/image.py:
	  If subtasks had an exception, retrigger the exception and stop.
2010-04-05 23:31:34 +00:00
Thomas Vander Stichele
8ea1dc025d * morituri/image/image.py:
Fix AudioLengthTask for the case where we don't have the decoder,
	  by instead of doing get_state, waiting for an ASYNC_DONE or ERROR
	  message.  Properly raise a gst.GError in that case.
	* morituri/common/task.py:
	  Add some debug.
	* morituri/test/test_image_image.py:
	  After this fix, we now catch the TYPE_NOT_FOUND because of an
	  empty stream instead of the later gst.QueryError.
	* morituri/test/test_common_encode.py:
	  Let us know what it is if not a gst.QueryError.
2010-04-05 23:20:40 +00:00
Thomas Vander Stichele
3000f0a1e7 * morituri/common/common.py:
add quoteParse function to quote properly for gst.parse_launch()
	* morituri/common/checksum.py:
	  Fix single quote problem.
	  use self.setException()
	* morituri/common/encode.py:
	  Fix single quote problem.
	* morituri/image/image.py:
	  Fix single quote problem.
	  Reraise gst.QueryError.
	* morituri/test/test_common_encode.py:
	* morituri/test/test_common_encode.py (added):
	  Add tests for unicode/single/double quote.
	* morituri/test/test_image_image.py:
	* morituri/test/test_common_checksum.py:
	  Add tests for single/double quote.
	* morituri/test/common.py:
	  add twisted-like failUnlessRaises to TestCase that returns
	  the exception, so we can check wrapped exceptions in TaskException.
2010-04-04 23:20:52 +00:00
Thomas Vander Stichele
6ae35a7a08 * morituri/common/task.py:
Wrap exceptions during tasks in a TaskException, storing the
	  message, for improved error reporting later on.
2010-04-04 23:10:44 +00:00
Thomas Vander Stichele
22a3554381 * morituri/common/encode.py:
* morituri/common/program.py:
	* morituri/image/image.py:
	* morituri/program/cdparanoia.py:
	* morituri/rip/cd.py:
	* morituri/rip/image.py:
	* morituri/rip/offset.py:
	  Move all gst-using imports inside functions and classes
	  to avoid 'import gst' eating our options.
	  Fixes #12.
2010-04-04 19:29:49 +00:00
Thomas Vander Stichele
17f800cdb3 remove result.py 2010-03-15 15:18:28 +00:00
Thomas Vander Stichele
c6d374bd16 * morituri/common/Makefile.am:
Add missing result.py
	* morituri/test/Makefile.am:
	* morituri/test/test_image_toc.py:
	* morituri/test/JoséGonzález.toc (added):
	* morituri/test/José González.toc (deleted):
	  automake doesn't handle spaces in names, so move it.
2010-03-15 15:16:14 +00:00