Commit Graph

249 Commits

Author SHA1 Message Date
Thomas Vander Stichele
0fab4515c6 pep8 fixes 2012-11-11 23:00:37 +00:00
Thomas Vander Stichele
e6a35146a7 pep8 fixes 2012-11-11 22:34:04 +00:00
Thomas Vander Stichele
77691747e5 pep8 fixes 2012-11-11 22:25:41 +00:00
Thomas Vander Stichele
29f71762da pep8 fixes 2012-11-11 22:23:25 +00:00
Thomas Vander Stichele
2f9dc86d86 pep8 fixes 2012-11-10 22:05:36 +00:00
Thomas Vander Stichele
ca7cd77dda pep8 fixes 2012-11-10 21:57:43 +00:00
Thomas Vander Stichele
a3fe7ba7e7 pep8 fixes 2012-11-10 21:57:06 +00:00
Thomas Vander Stichele
4ddca857f7 pep8 fixes 2012-11-10 21:56:30 +00:00
Thomas Vander Stichele
d248508f11 pep8 fixes 2012-11-10 21:53:16 +00:00
Thomas Vander Stichele
22d299c0ba pep8 fixes 2012-11-10 21:52:18 +00:00
Thomas Vander Stichele
6b45a9935b pep8 cleanup 2012-11-10 21:50:26 +00:00
Thomas Vander Stichele
fbb75dc91b pep8 cleanup 2012-11-10 21:48:04 +00:00
Thomas Vander Stichele
bbeaa7b940 remove whitespace 2012-11-10 20:27:17 +00:00
Thomas Vander Stichele
1da3c8cdfb * morituri/common/drive.py:
If cdio.get_devices_with_cap finds a single drive, it returns a
	  str instead of a list.  Work around that bug.  Fixes #102.
	* morituri/test/test_common_drive.py (added):
	* morituri/test/Makefile.am:
	  Add test for it.  Caught a bug in my first implementation, too!
2012-08-12 18:03:21 +00:00
Thomas Vander Stichele
1e2f8aa93f * morituri/common/Makefile.am:
* morituri/common/checksum.py:
	* morituri/common/encode.py:
	  Add a GstPipelineTask that lets us log.
	  Handle checksumming of small tracks better.
2012-08-12 12:32:09 +00:00
Thomas Vander Stichele
91b852b485 * morituri/common/checksum.py:
* morituri/common/encode.py:
	  Add a GstPipelineTask that lets us log.
	  Handle checksumming of small tracks better.
2012-08-12 12:26:33 +00:00
Thomas Vander Stichele
dbea1ca67f remove unused line 2012-08-12 11:52:24 +00:00
Thomas Vander Stichele
519baf6501 revert accidental commit 2012-07-12 09:40:00 +00:00
Thomas Vander Stichele
97101ec972 add new file 2012-07-12 09:38:59 +00:00
Thomas Vander Stichele
53db632202 * morituri/common/program.py:
Use a temp var to make code more readable.
2012-06-24 12:59:19 +00:00
Thomas Vander Stichele
8a7a69a361 * morituri/common/program.py:
Tell us which track is not in the db.
2012-06-24 12:56:37 +00:00
Thomas Vander Stichele
a5cd47d44c * morituri/common/musicbrainzngs.py:
Handle multiple artists correctly.
2012-04-01 20:42:46 +00:00
Thomas Vander Stichele
9bf5892dbd patch by: Christophe Fergeau <cfergeau@redhat.com)
* morituri/common/program.py:
	  When morituri finds multiple matches for a given release, it only
	  keeps the releases whose length are the closest to the CD being
	  ripped.
	  However, this currently interacts badly with the --release-id
	  parameter because this duration filtering is done before trying to
	  do the release-id matching. The release that the user has specified
	  may have been removed from the potential matches by the time the
	  release
	  id match is tried.
	  This commit removes the duration filtering when the user explicitly
	  specified a release id. I've observed this bug with the first disc
	  of The Wall (Experience Edition) by the Pink Floyd.
	  Fixes #91.
2012-04-01 20:41:55 +00:00
Thomas Vander Stichele
93f033dfca patch by: Christophe Fergeau <cfergeau@redhat.com)
* morituri/common/program.py:
	  When --release-id is used, we are not making guesses based on the
	  CD lengths, so the message saying that we picked the closest match
	  in duration, which can still trigger, is inappropriate.
2012-04-01 20:40:21 +00:00
Thomas Vander Stichele
c4e170daad * TODO:
* morituri/common/program.py:
	* morituri/rip/cd.py:
	  Add rip cd rip --release-id as an option to select the exact
	  release this disc is a part of.
	  Fixes Radiohead - Pablo Honey and U2 - Achtung Baby
2012-01-23 10:09:24 +00:00
Thomas Vander Stichele
69a1e731a3 * morituri/common/program.py:
Actually return the result from verifyTrack.
	  Debug the cache loading some more.  Make a note for a TODO.
2012-01-22 11:00:55 +00:00
Thomas Vander Stichele
61a5d2432f * morituri/common/musicbrainzngs.py:
Get the artist credit for a track/album; Fixes Gorky - Gorky.
2012-01-21 18:05:26 +00:00
Thomas Vander Stichele
a8a7a33b0a * morituri/common/checksum.py:
* morituri/common/program.py:
	  Fix/add logging.
2012-01-21 18:04:41 +00:00
Thomas Vander Stichele
c2838ad05c * morituri/rip/main.py:
* morituri/common/musicbrainzngs.py:
	* morituri/common/program.py:
	* morituri/rip/cd.py:
	  Add -R option to rip to record API results for debugging.
2011-10-28 17:49:36 +00:00
Thomas Vander Stichele
919076e720 doc fixes 2011-10-28 17:15:40 +00:00
Thomas Vander Stichele
cd6865c9d2 * morituri/common/musicbrainzngs.py:
Fix case of metadata not having length.
	  Fix case of release not having a date.
2011-10-28 16:36:39 +00:00
Thomas Vander Stichele
b5fc509747 * morituri/common/Makefile.am:
* morituri/common/musicbrainzngs.py:
	* morituri/common/program.py:
	* morituri/extern/Makefile.am:
	  Use musicbrainz NGS for ripping.
	  Can now rip Weezer, the Blue Album, both discs.
2011-10-22 15:52:57 +00:00
Thomas Vander Stichele
83d212a20e * morituri/rip/debug.py:
* morituri/common/musicbrainzngs.py (added):
	  Rewrite using python-musicbrainz-ngs.
	  Add rip debug musicbrainzngs command for testing,
	  seems to work on Weezer - Blue Album - disc 2
2011-10-19 22:37:37 +00:00
Thomas Vander Stichele
131535cde5 * morituri/common/musicbrainz.py:
* morituri/rip/debug.py:
	  Doc/output fixes.
2011-10-19 18:45:22 +00:00
Thomas Vander Stichele
6ab37720df * morituri/common/Makefile.am:
* morituri/common/musicbrainz.py:
	* morituri/common/program.py:
	* morituri/test/Makefile.am:
	* morituri/test/test_common_musicbrainz.py (added):
	* morituri/common/musicbrainz.py (added):
	  Split off musicbrainz-specific code.
2011-10-19 18:00:11 +00:00
Thomas Vander Stichele
2c27b73d09 * morituri/common/common.py:
Add shrinkPath to write shorter path names.
	* morituri/test/test_common_common.py (added):
	  Add test.
	* morituri/program/cdparanoia.py:
	  Catch ENAMETOOLONG and shrink path.
	* morituri/common/program.py:
	  Update track result's filename if it was shrunk.
	* morituri/rip/cd.py:
	  set the possibly shrunk path on the result.
2011-09-18 15:19:45 +00:00
Thomas Vander Stichele
516a01d47a * morituri/common/program.py:
Add Musicbrainz command.
2011-09-15 14:22:37 +00:00
Thomas Vander Stichele
513706eab6 add ivars to TrackMetadata 2011-09-04 14:21:29 +00:00
Thomas Vander Stichele
2ed3f8837f * morituri/common/program.py:
If any track is missing duration, set the whole album duration
	  to 0.
2011-09-04 14:19:29 +00:00
Thomas Vander Stichele
d2672cfa6a * morituri/common/gstreamer.py:
flacparse is busted in gst-plugins-good 0.10.30 too.
2011-09-04 14:17:47 +00:00
Thomas Vander Stichele
928e2e9ba7 print out duration before for comparison on musicbrainz 2011-08-15 09:03:13 +00:00
Thomas Vander Stichele
7cff47a8d4 * morituri/common/program.py:
Don't fail if there is no metadata.
2011-08-14 14:48:02 +00:00
Thomas Vander Stichele
e60b6d8441 * morituri/common/program.py:
* morituri/rip/debug.py:
	  Pychecker fixes.
2011-08-14 14:20:06 +00:00
Thomas Vander Stichele
2273db764c * morituri/common/program.py:
* morituri/rip/cd.py:
	  Always print MusicBrainz URL.
2011-08-14 12:20:30 +00:00
Thomas Vander Stichele
d43860bdfb * morituri/test/release.c7d919f4-3ea0-4c4b-a230-b3605f069440.xml:
Add release data for Bettie Serveert, Lamprey
	* morituri/test/test_common_program.py:
	  Add a test for parsing and getting the whole duration.
	* morituri/common/common.py:
	  Add a method to format time.
	* morituri/common/program.py:
	  Add duration to tracks and release metadatas.
	  When there are multiple matches, look up the closest in duration.
	  Make sure that multiple matches closest in duration contain same
	  artist and title.
	  Complain about the other ones.
	* morituri/image/table.py:
	  Add a method to calculate a duration from the table.
	* morituri/test/test_image_table.py:
	  Add a test for it.
2011-08-14 12:18:51 +00:00
Thomas Vander Stichele
63e705578d * doc/release:
Add note on actually running.
	* morituri/common/program.py:
	  Fix when running rip cd rip --unknown
2011-08-13 09:50:07 +00:00
Thomas Vander Stichele
8ec7bcbb9d * morituri/common/checksum.py:
* morituri/common/common.py:
	* morituri/common/encode.py:
	* morituri/image/image.py:
	* morituri/test/test_common_encode.py:
	  Moved quoteParse.
2011-08-05 19:18:10 +00:00
Thomas Vander Stichele
55c4bddfcf * morituri/common/Makefile.am:
* morituri/common/checksum.py:
	* morituri/common/gstreamer.py:
	* morituri/extern/Makefile.am:
	* morituri/extern/task/gstreamer.py:
	* morituri/common/gstreamer.py (added):
	  Extract function to remove audio parsers.
	  Fix up dist.
2011-08-05 19:04:53 +00:00
Thomas Vander Stichele
798a209195 * morituri/extern/task (added):
* morituri/extern/task/taskgtk.py (added):
	* morituri/extern/task/gstreamer.py (added):
	* morituri/extern/task/task.py (added):
	* morituri/common/taskgtk.py (deleted):
	* morituri/common/gstreamer.py (deleted):
	* morituri/common/task.py (deleted):
	  Move task-related modules into an extern directory so other
	  projects can use them.
	* morituri/common/checksum.py:
	* morituri/common/encode.py:
	* morituri/image/image.py:
	* morituri/program/cdparanoia.py:
	* morituri/program/cdrdao.py:
	* morituri/rip/cd.py:
	* morituri/rip/debug.py:
	* morituri/rip/image.py:
	* morituri/rip/main.py:
	* morituri/rip/offset.py:
	* morituri/test/test_common_checksum.py:
	* morituri/test/test_common_encode.py:
	* morituri/test/test_image_image.py:
	  Adapt.  Tests work.
2011-08-05 18:50:51 +00:00
Thomas Vander Stichele
5f8e0a5cc4 * morituri/common/task.py:
Log which task we are notifying progress on.
	* morituri/common/program.py:
	  Solve a problem where a release does not have an .id,
	  which means it's only half in musicbrainz (artist
	  and title, but no URL to the disc)
2011-07-09 10:06:56 +00:00