- Removed unused code not portable due to buffer() use
- raw_input() does not exist in Python 3
- Fixed octal constant syntax for Python 3
- Fixed TypeError
- Replace if not exists: makedirs(path) with single call: using makedirs(path, exist_ok=True)
- Class inherits from object, can be safely removed from bases in python3: pylint's useless-object-inheritance (W0235) check
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
- insert newlines after blocks of content
- strip quotes around creation time and offset
- Change offset value representation
- Clarify logger regular expressions
- Fix missing AccurateRip Summary field
- Read usage of time.gmtime(epoch) for generating datetime string
- fix missing dependency in travis
- install pycdio with specific version separately
Signed-off-by: itismadness <itismadness@users.noreply.github.com>
The attributes working_directory, disc_template, output_directory and offset are not defined during whipper cd info and they are only needed for ripping. self.program.getTable doesn't need output_path to gather the tocfile.
Therefore, this part is excluded, if the attributes don't exist and an offset of 0 is used.
Fixes issue #375.
Co-authored-by: gorgobacka <tho.b.j@gmx.de>
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
Signed-off-by: gorgobacka <tho.b.j@gmx.de>
This allows log parsers to always extract correct information about the "artist" and "title" fields: previously that was a problem if either (or both) of those fields contained a "-" character.
Fixes#416.
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
Output lines of cdrdao for single digit track numbers start with a
whitespace character.
Broken since #345 was merged.
Signed-off-by: Andreas Oberritter <obi@saftware.de>
If the eject command exits with an error, the output is logged as a WARNING. I don't think it's a good idea to mask those errors.
Closes#354.
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
If cdparanoia fails to analyze the drive, the drive is now marked as unable to defeat the cache.
Fixes#361.
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
The refactoring of `ReadTOCTask` in commit 3e79032b63
broke the `offset find` command. This commit fixes it again.
Signed-off-by: Volker Mische <volker.mische@gmail.com>
* Include MusicBrainz Release URL in log output
This also passes *all* metadata to the `result` object, giving loggers a
lot more (release) metadata to work with, in case custom, “3rd party”
loggers (or even ourselves in the future!) want to do something more
fancy or expansive with the metadata in the log file.
Fixes https://github.com/whipper-team/whipper/issues/381
Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
* Uppercase "url" in output: "URL"
Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
Instead of joining artist MBIDs with a ';' save them as multiple values
to the tag. (This is how Picard saves that tag.)
Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
