benya/whipper-gui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #658 from CommandMC/fix/tests

Browse Source 
Make tests more robust by mocking AccurateRip responses
This commit is contained in:
Merlijn Wajer
2026-02-07 11:00:31 +01:00
committed by GitHub
parent 4bf9d8cf8b 036fd82096
commit e1069c084e
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
whipper/test/test_common_accurip.py
View File

@@ -5,6 +5,8 @@ import sys
from io import StringIO from io import StringIO
from os.path import dirname, join from os.path import dirname, join
from unittest import TestCase from unittest import TestCase
from unittest.mock import MagicMock, patch
from urllib.error import HTTPError
from whipper.common.accurip import ( from whipper.common.accurip import (
calculate_checksums, get_db_entry, print_report, verify_result, calculate_checksums, get_db_entry, print_report, verify_result,
@@ -14,19 +16,20 @@ from whipper.result.result import RipResult, TrackResult
class TestAccurateRipResponse(TestCase): class TestAccurateRipResponse(TestCase):
@classmethod @patch(
def setUpClass(cls): "whipper.common.accurip.urlopen",
cls.path = 'c/1/2/dBAR-002-0000f21c-00027ef8-05021002.bin' MagicMock(side_effect=HTTPError("", 404, "Not Found", None, None)),
with open(join(dirname(__file__), cls.path[6:]), 'rb') as f: )
cls.entry = _split_responses(f.read())
cls.other_path = '4/8/2/dBAR-011-0010e284-009228a3-9809ff0b.bin'
def test_raises_entrynotfound_for_no_entry(self): def test_raises_entrynotfound_for_no_entry(self):
with self.assertRaises(EntryNotFound): with self.assertRaises(EntryNotFound):
get_db_entry('definitely_a_404') get_db_entry('definitely_a_404')
@patch(
"whipper.common.accurip.urlopen",
MagicMock(return_value=open(join(dirname(__file__), 'dBAR-002-0000f21c-00027ef8-05021002.bin'), 'rb')),
)
def test_AccurateRipResponse_parses_correctly(self): def test_AccurateRipResponse_parses_correctly(self):
responses = get_db_entry(self.path) responses = get_db_entry('c/1/2/dBAR-002-0000f21c-00027ef8-05021002.bin')
self.assertEqual(len(responses), 2) self.assertEqual(len(responses), 2)
self.assertEqual(responses[0].num_tracks, 2) self.assertEqual(responses[0].num_tracks, 2)