Review existing comments and add new ones
Also clarified a statement
This commit is contained in:
3
whipper/extern/task/task.py
vendored
3
whipper/extern/task/task.py
vendored
@@ -238,6 +238,7 @@ class Task(LogStub):
|
||||
method = getattr(l, methodName)
|
||||
try:
|
||||
method(self, *args, **kwargs)
|
||||
# FIXME: catching too general exception (Exception)
|
||||
except Exception as e:
|
||||
self.setException(e)
|
||||
|
||||
@@ -350,6 +351,7 @@ class BaseMultiTask(Task, ITaskListener):
|
||||
task.start(self.runner)
|
||||
self.debug('BaseMultiTask.next(): started task %d of %d: %r',
|
||||
self._task, len(self.tasks), task)
|
||||
# FIXME: catching too general exception (Exception)
|
||||
except Exception as e:
|
||||
self.setException(e)
|
||||
self.debug('Got exception during next: %r', self.exceptionMessage)
|
||||
@@ -503,6 +505,7 @@ class SyncRunner(TaskRunner, ITaskListener):
|
||||
try:
|
||||
self.debug('start task %r' % task)
|
||||
task.start(self)
|
||||
# FIXME: catching too general exception (Exception)
|
||||
except Exception as e:
|
||||
# getExceptionMessage uses global exception state that doesn't
|
||||
# hang around, so store the message
|
||||
|
||||
Reference in New Issue
Block a user