From a320f6a0a5e0e0240984a3d2ed3581292efaf657 Mon Sep 17 00:00:00 2001 From: Joe Date: Thu, 24 May 2018 17:19:14 +0200 Subject: [PATCH] Remove whipper's image retag feature (#269) Fixes #262. --- whipper/command/image.py | 78 +-------------------------------------- whipper/common/program.py | 5 --- 2 files changed, 1 insertion(+), 82 deletions(-) diff --git a/whipper/command/image.py b/whipper/command/image.py index 25d4f6d..2c5517c 100644 --- a/whipper/command/image.py +++ b/whipper/command/image.py @@ -18,12 +18,10 @@ # You should have received a copy of the GNU General Public License # along with whipper. If not, see . -import os import sys from whipper.command.basecommand import BaseCommand from whipper.common import accurip, config, program -from whipper.common import encode from whipper.extern.task import task from whipper.image import image from whipper.result import result @@ -32,78 +30,6 @@ import logging logger = logging.getLogger(__name__) -class Retag(BaseCommand): - summary = "retag image files" - description = """ -Retags the image from the given .cue files with tags obtained from MusicBrainz. -""" - - def add_arguments(self): - self.parser.add_argument('cuefile', nargs='+', action='store', - help="cue file to load rip image from") - self.parser.add_argument( - '-R', '--release-id', - action="store", dest="release_id", - help="MusicBrainz release id to match to (if there are multiple)" - ) - self.parser.add_argument( - '-p', '--prompt', - action="store_true", dest="prompt", - help="Prompt if there are multiple matching releases" - ) - self.parser.add_argument( - '-c', '--country', - action="store", dest="country", - help="Filter releases by country" - ) - - def do(self): - - prog = program.Program(config.Config(), stdout=sys.stdout) - runner = task.SyncRunner() - - for arg in self.options.cuefile: - sys.stdout.write('Retagging image %r\n' % arg) - arg = arg.decode('utf-8') - cueImage = image.Image(arg) - cueImage.setup(runner) - - mbdiscid = cueImage.table.getMusicBrainzDiscId() - sys.stdout.write('MusicBrainz disc id is %s\n' % mbdiscid) - - sys.stdout.write("MusicBrainz lookup URL %s\n" % - cueImage.table.getMusicBrainzSubmitURL()) - prog.metadata = prog.getMusicBrainz(cueImage.table, mbdiscid, - release=self.options.release_id, # noqa: E501 - country=self.options.country, - prompt=self.options.prompt) - - if not prog.metadata: - print 'Not in MusicBrainz database, skipping' - continue - - prog.metadata.discid = mbdiscid - - # FIXME: this feels like we're poking at internals. - prog.cuePath = arg - prog.result = result.RipResult() - for track in cueImage.table.tracks: - path = cueImage.getRealPath(track.indexes[1].path) - - taglist = prog.getTagList(track.number) - logger.debug( - 'possibly retagging %r from cue path %r with taglist %r', - path, arg, taglist) - t = encode.SafeRetagTask(path, taglist) - runner.run(t) - path = os.path.basename(path) - if t.changed: - print 'Retagged %s' % path - else: - print '%s already tagged correctly' % path - print - - class Verify(BaseCommand): summary = "verify image" description = """ @@ -145,10 +71,8 @@ class Image(BaseCommand): summary = "handle images" description = """ Handle disc images. Disc images are described by a .cue file. -Disc images can be encoded to another format (for example, to make a -compressed encoding), retagged and verified. +Disc images can be verified. """ subcommands = { 'verify': Verify, - 'retag': Retag } diff --git a/whipper/common/program.py b/whipper/common/program.py index 92cefdc..366d4f4 100644 --- a/whipper/common/program.py +++ b/whipper/common/program.py @@ -542,11 +542,6 @@ class Program: trackResult.filename = t.path logger.info('Filename changed to %r', trackResult.filename) - def retagImage(self, runner, taglists): - cueImage = image.Image(self.cuePath) - t = image.ImageRetagTask(cueImage, taglists) - runner.run(t) - def verifyImage(self, runner, table): """ verify table against accuraterip and cue_path track lengths