From 8181cacca5fc7f67d7416a86744406bb69edde97 Mon Sep 17 00:00:00 2001 From: ABCbum Date: Mon, 23 Dec 2019 23:08:28 +0700 Subject: [PATCH] Update README, dependencies and supporting files for cover art feature Signed-off-by: ABCbum Co-authored-by: JoeLametta Signed-off-by: JoeLametta --- .travis.yml | 2 +- Dockerfile | 1 + README.md | 7 +++++++ setup.py | 3 +++ 4 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 3dd3a75..7425673 100644 --- a/.travis.yml +++ b/.travis.yml @@ -24,7 +24,7 @@ install: # Dependencies - sudo apt-get -qq update - pip install --upgrade -qq pip - - sudo apt-get -qq install cdparanoia cdrdao flac gir1.2-glib-2.0 libcdio-dev libgirepository1.0-dev libiso9660-dev libsndfile1-dev sox swig libcdio-utils libdiscid0 + - sudo apt-get -qq install cdparanoia cdrdao flac gir1.2-glib-2.0 libcdio-dev libgirepository1.0-dev libiso9660-dev libsndfile1-dev sox swig libcdio-utils libdiscid0 python3-pil # newer version of pydcio requires newer version of libcdio than travis has - pip install pycdio==0.21 # install rest of dependencies diff --git a/Dockerfile b/Dockerfile index 73cb13d..ba85f15 100644 --- a/Dockerfile +++ b/Dockerfile @@ -21,6 +21,7 @@ RUN apt-get update && apt-get install --no-install-recommends -y \ python3-gi \ python3-musicbrainzngs \ python3-mutagen \ + python3-pil \ python3-pip \ python3-requests \ python3-ruamel.yaml \ diff --git a/README.md b/README.md index 57a25d4..27e8be0 100644 --- a/README.md +++ b/README.md @@ -155,6 +155,13 @@ PyPI installable dependencies are listed in the [requirements.txt](https://githu `pip install -r requirements.txt` +### Optional dependencies +- [pillow](https://pypi.org/project/Pillow/), for completely supporting the cover art feature (`embed` and `complete` option values won't work otherwise). + +This dependency isn't listed in the `requirements.txt`, to install it just issue the following command: + +`pip install Pillow` + ### Fetching the source code Change to a directory where you want to put whipper source code (for example, `$HOME/dev/ext` or `$HOME/prefix/src`) diff --git a/setup.py b/setup.py index 96bebf5..d5d41e3 100644 --- a/setup.py +++ b/setup.py @@ -16,6 +16,9 @@ setup( libraries=['sndfile'], sources=['src/accuraterip-checksum.c']) ], + extras_require={ + 'cover_art': ["pillow"] + }, entry_points={ 'console_scripts': [ 'whipper = whipper.command.main:main'