work around GStreamer bug in flacdec for really short files

morituri/common/checksum.py

@@ -101,49 +101,65 @@ class ChecksumTask(log.Loggable, gstreamer.GstPipelineTask):
             appsink name=sink sync=False emit-signals=True
             ''' % gstreamer.quoteParse(self._path).encode('utf-8')
 
+    def _getSampleLength(self):
+        # get length in samples of file
+        sink = self.pipeline.get_by_name('sink')
+
+        self.debug('query duration')
+        try:
+            length, qformat = sink.query_duration(gst.FORMAT_DEFAULT)
+        except gst.QueryError, e:
+            self.setException(e)
+            return None
+
+        # wavparse 0.10.14 returns in bytes
+        if qformat == gst.FORMAT_BYTES:
+            self.debug('query returned in BYTES format')
+            length /= 4
+        self.debug('total sample length of file: %r', length)
+
+        return length
+
+
     def paused(self):
         sink = self.pipeline.get_by_name('sink')
 
-        if self._sampleLength < 0:
+        length = self._getSampleLength()
-            self.debug('query duration')
+        if length is None:
-            try:
+            return
-                length, qformat = sink.query_duration(gst.FORMAT_DEFAULT)
-            except gst.QueryError, e:
-                self.setException(e)
-                return
 
-            # wavparse 0.10.14 returns in bytes
+        if self._sampleLength < 0:
-            if qformat == gst.FORMAT_BYTES:
-                self.debug('query returned in BYTES format')
-                length /= 4
-            self.debug('total sample length of file: %r', length)
             self._sampleLength = length - self._sampleStart
             self.debug('sampleLength is queried as %d samples',
                 self._sampleLength)
         else:
             self.debug('sampleLength is known, and is %d samples' %
                 self._sampleLength)
+
         self._sampleEnd = self._sampleStart + self._sampleLength - 1
         self.debug('sampleEnd is sample %d' % self._sampleEnd)
 
         self.debug('event')
 
 
-        # the segment end only is respected since -good 0.10.14.1
+        if self._sampleStart == 0 and self._sampleEnd + 1 == length:
-        event = gst.event_new_seek(1.0, gst.FORMAT_DEFAULT,
+            self.debug('No need to seek, crcing full file')
-            gst.SEEK_FLAG_FLUSH,
+        else:
-            gst.SEEK_TYPE_SET, self._sampleStart,
+            # the segment end only is respected since -good 0.10.14.1
-            gst.SEEK_TYPE_SET, self._sampleEnd + 1) # half-inclusive interval
+            event = gst.event_new_seek(1.0, gst.FORMAT_DEFAULT,
-        self.debug('CRCing %r from sector %d to sector %d' % (
+                gst.SEEK_FLAG_FLUSH,
-            self._path,
+                gst.SEEK_TYPE_SET, self._sampleStart,
-            self._sampleStart / common.SAMPLES_PER_FRAME,
+                gst.SEEK_TYPE_SET, self._sampleEnd + 1) # half-inclusive
-            (self._sampleEnd + 1) / common.SAMPLES_PER_FRAME))
+            self.debug('CRCing %r from frame %d to frame %d (excluded)' % (
-        # FIXME: sending it with sampleEnd set screws up the seek, we don't get
+                self._path,
-        # everything for flac; fixed in recent -good
+                self._sampleStart / common.SAMPLES_PER_FRAME,
-        result = sink.send_event(event)
+                (self._sampleEnd + 1) / common.SAMPLES_PER_FRAME))
-        self.debug('event sent, result %r', result)
+            # FIXME: sending it with sampleEnd set screws up the seek, we
-        if not result:
+            # don't get # everything for flac; fixed in recent -good
-            self.error('Failed to select samples with GStreamer seek event')
+            result = sink.send_event(event)
+            self.debug('event sent, result %r', result)
+            if not result:
+                self.error('Failed to select samples with GStreamer seek event')
         sink.connect('new-buffer', self._new_buffer_cb)
         sink.connect('eos', self._eos_cb)
 

morituri/common/encode.py

@@ -167,6 +167,7 @@ class EncodeTask(ctask.GstPipelineTask):
         self._inpath = inpath
         self._outpath = outpath
         self._taglist = taglist
+        self._length = 0 # in samples
 
         self._level = None
         self._peakdB = None
@@ -299,8 +300,10 @@ class EncodeTask(ctask.GstPipelineTask):
 
         if self._duration:
             self.warning('GStreamer level element did not send messages.')
-        # workaround for when the file is too short to have volume ?
+            # workaround for when the file is too short to have volume ?
-        # self.peak = 0.0
+            if self._length == common.SAMPLES_PER_FRAME:
+                self.warning('only one frame of audio, setting peak to 0.0')
+                self.peak = 0.0
 
 
 class TagReadTask(ctask.GstPipelineTask):