From 2c464bc7322f4a8f42fec62ff4486963f19bcc49 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Frederik=20=E2=80=9CFreso=E2=80=9D=20S=2E=20Olesen?= Date: Wed, 13 Feb 2019 15:03:31 +0100 Subject: [PATCH] Fix MusicBrainz nomenclature: track vs. recording MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit For historical reasons there is some confusion between Tracks[1] and Recordings[2] in MusicBrainz. Essentially what should be saved to `MUSICBRAINZ_TRACKID` is the Recording MBID—which is what whipper is correctly doing, but the value storing this value was called `mbidTrack` rather than `mbidRecording`, which could potentially cause confusion. [1] https://musicbrainz.org/doc/Track [2] https://musicbrainz.org/doc/Recording Signed-off-by: Frederik “Freso” S. Olesen --- whipper/common/program.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/whipper/common/program.py b/whipper/common/program.py index d07df5c..1cb67b1 100644 --- a/whipper/common/program.py +++ b/whipper/common/program.py @@ -393,7 +393,7 @@ class Program: track = self.metadata.tracks[number - 1] trackArtist = track.artist title = track.title - mbidTrack = track.mbid + mbidRecording = track.mbid mbidTrackArtist = track.mbidArtist except IndexError as e: logger.error('no track %d found, %r', number, e) @@ -420,7 +420,7 @@ class Program: tags['DATE'] = self.metadata.release if number > 0: - tags['MUSICBRAINZ_TRACKID'] = mbidTrack + tags['MUSICBRAINZ_TRACKID'] = mbidRecording tags['MUSICBRAINZ_ARTISTID'] = mbidTrackArtist tags['MUSICBRAINZ_ALBUMID'] = mbidRelease tags['MUSICBRAINZ_ALBUMARTISTID'] = mbidReleaseArtist