From 2b286be91cd3c697b75fd7f93733efbfea47ddd2 Mon Sep 17 00:00:00 2001 From: JoeLametta Date: Sat, 17 Nov 2018 09:05:34 +0000 Subject: [PATCH] Update failing AccurateRipResponse tests (#334) * Update failing AccurateRipResponse tests [1/2] The failures seem to be caused by a remote metadata change (metadata from AccurateRip about a release ID changed) which means some of the asserts related to a specific release ID are failing. I've fixed this issue with two commits. This is part 1: here I've updated the confidence values of two tracks making it agree with AccurateRip's remote. * Update failing AccurateRipResponse tests [2/2] This is part 2: here I've replaced the outdated AccurateRip bin file with a freshly downloaded one. --- .../test/dBAR-002-0000f21c-00027ef8-05021002.bin | Bin 62 -> 62 bytes whipper/test/test_common_accurip.py | 8 ++++---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/whipper/test/dBAR-002-0000f21c-00027ef8-05021002.bin b/whipper/test/dBAR-002-0000f21c-00027ef8-05021002.bin index 6ff761c6e7533df870442a1bcb2dbf9a3a7f16f3..8c804e6e6ebf526ff6a58e6eceacb855a3d2ece6 100644 GIT binary patch delta 23 bcmcDso1i1ay837N9R?s^J$z~UT@V8RUAG5S delta 23 bcmcDso1i1avifKF9R?s^IecmQT@V8RU7QC~ diff --git a/whipper/test/test_common_accurip.py b/whipper/test/test_common_accurip.py index b28193c..ec6fe8a 100644 --- a/whipper/test/test_common_accurip.py +++ b/whipper/test/test_common_accurip.py @@ -78,8 +78,8 @@ class TestAccurateRipResponse(TestCase): self.assertEqual(responses[1].discId1, '0000f21c') self.assertEqual(responses[1].discId2, '00027ef8') self.assertEqual(responses[1].cddbDiscId, '05021002') - self.assertEqual(responses[1].confidences[0], 4) - self.assertEqual(responses[1].confidences[1], 4) + self.assertEqual(responses[1].confidences[0], 5) + self.assertEqual(responses[1].confidences[1], 5) self.assertEqual(responses[1].checksums[0], 'dc77f9ab') self.assertEqual(responses[1].checksums[1], 'dd97d2c3') @@ -203,7 +203,7 @@ class TestVerifyResult(TestCase): 'v2': { 'CRC': 'dc77f9ab', 'DBCRC': 'dc77f9ab', - 'DBConfidence': 4, + 'DBConfidence': 5, }, 'DBMaxConfidence': 12, 'DBMaxConfidenceCRC': '284fc705', @@ -217,7 +217,7 @@ class TestVerifyResult(TestCase): 'v2': { 'CRC': 'dd97d2c3', 'DBCRC': 'dd97d2c3', - 'DBConfidence': 4, + 'DBConfidence': 5, }, 'DBMaxConfidence': 20, 'DBMaxConfidenceCRC': '9cc1f32e',