From 3416d44afa3aee4fbb33ef32477d91e11e8646b4 Mon Sep 17 00:00:00 2001 From: benya Date: Sun, 8 Mar 2026 21:45:23 +0300 Subject: [PATCH] fix(web): harden chat info profile loading for partial failures --- docs/core-checklist-status.md | 2 +- web/src/components/ChatInfoPanel.tsx | 12 ++++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/docs/core-checklist-status.md b/docs/core-checklist-status.md index c713dae..ddeaf9d 100644 --- a/docs/core-checklist-status.md +++ b/docs/core-checklist-status.md @@ -31,7 +31,7 @@ Legend: 22. Text Formatting - `PARTIAL` (bold/italic/underline/spoiler/mono/links + strikethrough + quote/code block; toolbar still evolving) 23. Groups - `PARTIAL` (create/add/remove/invite link; join-by-invite and invite permissions covered by integration tests; members API now returns profile fields (`username/name/avatar_url`) and web Chat Info consumes them to avoid extra per-member profile requests; add-member search also shows avatars; advanced moderation still partial) 24. Roles - `DONE` (owner/admin/member) -25. Admin Rights - `PARTIAL` (delete/pin/edit info + explicit ban APIs for groups/channels including ban list endpoint; web Chat Info now shows searchable `Banned users` with both inline and right-click `Unban` actions for owner/admin, member search, avatars in moderation lists, invite-link copy/regenerate actions, ban metadata (`who banned/when`), and explicit member action button for touch/trackpad UX; integration tests cover channel member read-only, channel admin full-delete, channel message delete-for-all permissions, group profile edit permissions, owner-only role management rules, and admin-visible/member-forbidden ban-list access; remaining UX moderation tools limited) +25. Admin Rights - `PARTIAL` (delete/pin/edit info + explicit ban APIs for groups/channels including ban list endpoint; web Chat Info now shows searchable `Banned users` with both inline and right-click `Unban` actions for owner/admin, member search, avatars in moderation lists, invite-link copy/regenerate actions, ban metadata (`who banned/when`), explicit member action button for touch/trackpad UX, and resilient profile hydration (`allSettled`) for partially missing users; integration tests cover channel member read-only, channel admin full-delete, channel message delete-for-all permissions, group profile edit permissions, owner-only role management rules, and admin-visible/member-forbidden ban-list access; remaining UX moderation tools limited) 26. Channels - `PARTIAL` (create/post/edit/delete/subscribe/unsubscribe; integration tests now also cover invite-link permissions (member forbidden, admin allowed); UX edge-cases still polishing) 27. Channel Types - `DONE` (public/private) 28. Notifications - `PARTIAL` (browser notifications + mute/settings; chat mute is propagated in chat list payload, honored by web realtime notifications with mention override, and mute toggle now syncs instantly in chat store; backend now emits `chat_updated` after notification mute/unmute for cross-tab consistency; no mobile push infra) diff --git a/web/src/components/ChatInfoPanel.tsx b/web/src/components/ChatInfoPanel.tsx index 305768e..482ce06 100644 --- a/web/src/components/ChatInfoPanel.tsx +++ b/web/src/components/ChatInfoPanel.tsx @@ -155,9 +155,11 @@ export function ChatInfoPanel({ chatId, open, onClose }: Props) { } } if (missingIds.length) { - const profiles = await Promise.all(missingIds.map((id) => getUserById(id))); + const profiles = await Promise.allSettled(missingIds.map((id) => getUserById(id))); for (const profile of profiles) { - byId[profile.id] = profile; + if (profile.status === "fulfilled") { + byId[profile.value.id] = profile.value; + } } } setMemberUsers(byId); @@ -169,10 +171,12 @@ export function ChatInfoPanel({ chatId, open, onClose }: Props) { const nextBans = await listChatBans(targetChatId); setBans(nextBans); const ids = [...new Set(nextBans.flatMap((item) => [item.user_id, item.banned_by_user_id]))]; - const profiles = await Promise.all(ids.map((id) => getUserById(id))); + const profiles = await Promise.allSettled(ids.map((id) => getUserById(id))); const byId: Record = {}; for (const profile of profiles) { - byId[profile.id] = profile; + if (profile.status === "fulfilled") { + byId[profile.value.id] = profile.value; + } } setBannedUsers(byId); } catch {